[marcalff]

DO NOT MERGE

Changes

Please provide a brief description of the changes here.

• Proof of concept code, to investigate noexcept related clang-tidy warnings.
• Remove noexcept from all SDK internal code
• Keep noexcept for SDK entry points (for example, StartSpan)

For significant contributions please make sure you have completed the following items:

• CHANGELOG.md updated for non-trivial changes
• Unit tests have been added
• Changes in public API reviewed

[codecov]

Codecov Report

❌ Patch coverage is 94.23077% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.65%. Comparing base (ac7b87a) to head (39fd37d).

Files with missing lines	Patch %	Lines
sdk/src/trace/tracer.cc	60.00%	2 Missing ⚠️
sdk/src/trace/tracer_provider.cc	60.00%	2 Missing ⚠️
...clude/opentelemetry/sdk/logs/readable_log_record.h	0.00%	1 Missing ⚠️
sdk/include/opentelemetry/sdk/logs/recordable.h	0.00%	1 Missing ⚠️
...telemetry/sdk/metrics/state/multi_metric_storage.h	80.00%	1 Missing ⚠️
...ntelemetry/sdk/metrics/view/attributes_processor.h	85.72%	1 Missing ⚠️
sdk/include/opentelemetry/sdk/trace/recordable.h	66.67%	1 Missing ⚠️
sdk/src/logs/exporter.cc	0.00%	1 Missing ⚠️
sdk/src/logs/readable_log_record.cc	66.67%	1 Missing ⚠️
sdk/src/metrics/meter_provider.cc	75.00%	1 Missing ⚠️
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4713      +/-   ##
==========================================
- Coverage   86.69%   86.65%   -0.04%     
==========================================
  Files         527      527              
  Lines       20902    20903       +1     
==========================================
- Hits        18119    18111       -8     
- Misses       2783     2792       +9     

Files with missing lines	Coverage Δ
...clude/opentelemetry/sdk/common/atomic_unique_ptr.h	100.00% <100.00%> (ø)
...include/opentelemetry/sdk/common/attribute_utils.h	95.59% <100.00%> (-0.03%)	⬇️
...include/opentelemetry/sdk/common/circular_buffer.h	100.00% <100.00%> (ø)
...e/opentelemetry/sdk/common/circular_buffer_range.h	100.00% <100.00%> (ø)
...de/opentelemetry/sdk/common/custom_hash_equality.h	100.00% <100.00%> (ø)
...y/sdk/instrumentationscope/instrumentation_scope.h	100.00% <ø> (ø)
...etry/sdk/instrumentationscope/scope_configurator.h	100.00% <100.00%> (ø)
...pentelemetry/sdk/logs/batch_log_record_processor.h	100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/logs/exporter.h	100.00% <100.00%> (ø)
...include/opentelemetry/sdk/logs/log_record_limits.h	100.00% <100.00%> (ø)
... and 78 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mateenali66]

built cda0cd10 (macOS, ABI v1), 1147/1147 tests pass. three things for when this becomes real PRs.

1. MetricReader::Collect losing noexcept makes the catch in PeriodicExportingMetricReader::CollectAndExportOnce() reachable, and it returns before advancing force_flush_notified_sequence_ (periodic_exporting_metric_reader.cc:184-204). with an exporter whose Export() throws, ForceFlush(2s) times out and MeterProvider::Shutdown() with the default timeout never returns.
2. Span::Span and its attribute lambda stay noexcept (span.cc:62, :81), so a throwing OnStart() terminates inside StartSpan() before the catch at tracer.cc:170. #4700 now catches inside each exporter's MakeRecordable(), the opposite convention.
3. part of the clang-tidy drop is the check not seeing through pure virtuals. with TreatFunctionsWithoutSpecificationAsThrowing: OnlyUndefined (clang-tidy 23) new escapes show at Span::Span and Logger::EmitLogRecord.

is TracerProvider::Shutdown() meant to stay an entry point? a throwing exporter Shutdown() now reaches the caller.

[mateenali66]

716a672 takes noexcept off the two lambdas in StartSpan, but Span::Span is still noexcept (span.h:38, span.cc:62) and calls OnStart() last. at 39fd37d a processor whose OnStart() throws still aborts inside StartSpan(). with only that noexcept removed, the catch at tracer.cc:167 takes it and the call returns the noop span.

the attribute lambda at span.cc:81 is still noexcept too, while Recordable::SetAttribute no longer is.

points 1 and 3 from my last review are unchanged at this head.