Repository navigation
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-09 09:54 UTC Review the latest changes. Status above doesn't look right?
|
cce1013 to
622236e
Compare
…tests Set from_version to v0.165.0 and reference_url to open-telemetry#52626, regenerate metadata, and expand unit and translateV2 tests for receiver.prometheus_remote_write.disableJobSplit.
58724c9 to
28ca409
Compare
…tests Set from_version to v0.165.0 and reference_url to open-telemetry#52626, regenerate metadata, and expand unit and translateV2 tests for receiver.prometheus_remote_write.disableJobSplit.
|
Needs rebase. |
ArthurSens
left a comment
There was a problem hiding this comment.
Isn't this doing the exact opposite of what is being described in open-telemetry/opentelemetry-specification#5356?
Rebased onto
@ArthurSens In open-telemetry/opentelemetry-specification#5356 (comment) (and #52626 (comment)), @krajorama and I agreed to treat the |
…tests Set from_version to v0.165.0 and reference_url to open-telemetry#52626, regenerate metadata, and expand unit and translateV2 tests for receiver.prometheus_remote_write.disableJobSplit.
28ca409 to
754fa26
Compare
|
Would it be ok to proceed with this PR only once we make the appropriate change in the spec? I'd love to avoid the possibility of us making a change here and eventually disagreeing on the spec change |
This introduces an alpha feature gate `receiver.prometheus_remote_write.preserveJobLabel` which, when enabled, prevents the receiver from splitting the prometheus job label into service.namespace and service.name, preserving the full job label as service.name.
…tests Set from_version to v0.165.0 and reference_url to open-telemetry#52626, regenerate metadata, and expand unit and translateV2 tests for receiver.prometheus_remote_write.disableJobSplit.
@ArthurSens Since the existing spec on |
754fa26 to
d9e8777
Compare
Description
This PR aligns the
prometheusremotewritereceiverwith the standard pull-basedprometheusreceiver, ensuring that thejoblabel is consistently mapped directly toservice.namewithout splitting in both receivers. This prevents us from having to codify divergent receiver behaviors in the OpenTelemetry specification.To ensure a safe migration path for existing users who rely on the legacy splitting behavior, this PR introduces an
alphafeature gatereceiver.prometheus_remote_write.disableJobSplit.When this feature gate is enabled, the receiver preserves the
joblabel as-is and maps the entire string directly toservice.name, omittingservice.namespace. Because it starts in thealphastage, the gate is disabled by default, completely preserving the legacy splitting behavior. This provides a safe transition path to eventually deprecate the splitting logic.Testing
TestParseJobAndInstanceFeatureGateto verify that when the feature gate is enabled, the job string is preserved exactly asservice.name.Documentation
Updated
metadata.yamlto include the new feature gate description.Authorship