feat: add RobotCollision.msg to rmf_fleet_msgs#90
Merged
mxgrey merged 1 commit intoopen-rmf:mainfrom Apr 14, 2026
Merged
Conversation
This message is added to broadcast collision events and the location of the respective robot during emergency stops. Required for open-rmf/rmf_simulation#160 and resolves open-rmf/rmf_simulation#159. Signed-off-by: Aditya Pachauri <[email protected]>
2 tasks
luca-della-vedova
approved these changes
Apr 9, 2026
Member
luca-della-vedova
left a comment
luca-della-vedova
left a comment
There was a problem hiding this comment.
Generally LGTM, upstream PR will need to be updated since it still uses std_msgs/String
Contributor
Author
|
I have the new message update ready locally, and I will push it to #160 the exact moment this gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
This PR adds a new RobotCollision.msg to the rmf_fleet_msgs package. It is added to broadcast collision events and the location of the respective robot when an emergency stop is triggered.
Required for: open-rmf/rmf_simulation#160
Resolves: open-rmf/rmf_simulation#159
Implementation description
Following the discussion in open-rmf/rmf_simulation#160, this message utilizes the existing rmf_fleet_msgs/Location message structure to accurately use the level_name alongwith the x, y, yaw, and t coordinates.
GenAI Use
We follow OSRA's policy on GenAI tools
Generated-by: Used Gemini AI to format the PR description.