Skip to content

jakx: Commit existing work from other PRs #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xTVaser merged 38 commits into from
Jan 1, 2026

tests: disable type checks for jakx for now

7d1757c
Select commit
Loading
Failed to load commit list.
Merged

jakx: Commit existing work from other PRs #4112

tests: disable type checks for jakx for now
7d1757c
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Dec 31, 2025 in 0s

72 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 72
           

Complexity increasing per file
==============================
- game/graphics/opengl_renderer/OpenGLRenderer.cpp  4
- decompiler/analysis/find_defpartgroup.cpp  2
- decompiler/analysis/insert_lets.cpp  8
- common/goal_constants.h  1
- game/sce/sif_ee.cpp  1
- decompiler/util/DecompilerTypeSystem.cpp  2
- decompiler/level_extractor/extract_tie.cpp  5
- game/graphics/texture/TexturePool.cpp  2
- common/audio/audio_formats.cpp  1
- decompiler/ObjectFile/ObjectFileDB.cpp  3
- common/symbols.h  2
- decompiler/data/streamed_audio.cpp  1
- decompiler/data/StrFileReader.cpp  1
- decompiler/config.cpp  1
- decompiler/data/tpage.cpp  1
- decompiler/analysis/find_skelgroups.cpp  3
- decompiler/data/game_text.cpp  18
- decompiler/data/dir_tpages.cpp  1
- decompiler/analysis/cfg_builder.cpp  4
- game/runtime.cpp  3
- game/graphics/opengl_renderer/EyeRenderer.cpp  2
- game/graphics/opengl_renderer/ocean/OceanMidAndFar.cpp  2
- game/graphics/opengl_renderer/ocean/OceanTexture.cpp  1
- game/graphics/opengl_renderer/ocean/OceanNear.cpp  1
- game/graphics/opengl_renderer/CollideMeshRenderer.cpp  1
- game/kernel/common/kmachine.cpp  2
- test/goalc/test_type_consistency.cpp  1
- decompiler/types2/ForwardProp.cpp  6
- tools/type_searcher/main.cpp  1
- game/graphics/opengl_renderer/sprite/Sprite3.cpp  4
- game/graphics/opengl_renderer/sprite/Sprite3_Distort.cpp  1
- common/versions/versions.cpp  3
- game/graphics/opengl_renderer/BlitDisplays.cpp  1
- game/graphics/opengl_renderer/TextureAnimator.cpp  6
- game/graphics/opengl_renderer/TextureAnimatorDefs.cpp  1
- decompiler/decompilation_process.cpp  3
- game/overlord/jakx/ramdisk.cpp  4
- game/overlord/jakx/vag.cpp  170
- game/overlord/jakx/stream.cpp  38
- game/kernel/jakx/kmalloc.cpp  3
- game/graphics/jakx_texture_remap.cpp  4
- game/overlord/jakx/streamlist.cpp  53
- game/overlord/jakx/srpc.cpp  119
- game/overlord/jakx/ssound.cpp  135
- game/overlord/jakx/dvd_driver.h  1
- game/overlord/jakx/isocommon.h  3
- game/overlord/jakx/spustreams.cpp  229
- game/overlord/jakx/basefile.cpp  44
- game/kernel/jakx/kmachine.cpp  57
- game/overlord/jakx/overlord.cpp  11
- game/overlord/jakx/basefilesystem.cpp  4
- game/overlord/jakx/pagemanager.cpp  127
- game/kernel/jakx/kmachine_extras.cpp  185
- game/kernel/jakx/kdgo.cpp  11
- game/kernel/jakx/kboot.cpp  26
- game/overlord/jakx/iso.cpp  298
- game/kernel/jakx/klisten.cpp  11
- game/kernel/jakx/kmachine_extras.h  2
- game/overlord/jakx/soundcommon.cpp  2
- game/kernel/jakx/fileio.cpp  51
- game/overlord/jakx/dvd_driver.cpp  93
- game/overlord/jakx/dma.cpp  73
- game/kernel/jakx/ksound.cpp  1
- game/overlord/jakx/isocommon.cpp  25
- game/overlord/jakx/list.cpp  7
- game/overlord/jakx/sbank.cpp  34
- game/overlord/jakx/init.cpp  1
- game/kernel/jakx/kscheme.cpp  304
- game/overlord/jakx/iso_api.cpp  25
- game/overlord/jakx/overlord.h  2
- game/kernel/jakx/kscheme.h  4
- game/overlord/jakx/vblank_handler.cpp  39
- game/kernel/jakx/klink.cpp  169
- game/kernel/jakx/kprint.cpp  119
- game/overlord/jakx/iso_queue.cpp  129
- game/overlord/jakx/iso_cd.cpp  76
         

Clones added
============
- decompiler/util/sparticle_decompile.cpp  7
- decompiler/data/game_text.cpp  2
- game/overlord/jakx/ramdisk.cpp  1
- game/overlord/jakx/list.h  1
- game/overlord/jakx/pagemanager.h  1
- game/overlord/jakx/vag.cpp  5
- game/overlord/jakx/stream.cpp  6
- game/kernel/jakx/kmalloc.cpp  1
- game/graphics/jakx_texture_remap.cpp  1
- game/overlord/jakx/srpc.h  1
- game/overlord/jakx/streamlist.cpp  1
- game/overlord/jakx/srpc.cpp  3
- game/overlord/jakx/iso_cd.h  1
- game/overlord/jakx/ssound.cpp  41
- game/overlord/jakx/dvd_driver.h  1
- game/overlord/jakx/isocommon.h  1
- game/overlord/jakx/spustreams.cpp  9
- game/overlord/jakx/basefile.cpp  3
- game/kernel/jakx/kmachine.cpp  27
- game/overlord/jakx/overlord.cpp  2
- game/overlord/jakx/basefilesystem.cpp  1
- game/overlord/jakx/pagemanager.cpp  9
- game/overlord/jakx/iso.h  1
- game/kernel/jakx/kmachine_extras.cpp  70
- game/kernel/jakx/kdgo.cpp  8
- game/overlord/jakx/iso_queue.h  1
- game/kernel/jakx/kboot.cpp  5
- game/overlord/jakx/iso.cpp  14
- game/kernel/jakx/klisten.cpp  6
- game/kernel/jakx/kmachine_extras.h  7
- game/overlord/jakx/basefilesystem.h  1
- game/overlord/jakx/soundcommon.cpp  2
- game/kernel/jakx/fileio.cpp  10
- game/overlord/jakx/dvd_driver.cpp  6
- game/overlord/jakx/dma.cpp  2
- game/kernel/jakx/ksound.cpp  2
- game/kernel/jakx/kdgo.h  2
- game/kernel/jakx/klisten.h  2
- game/overlord/jakx/isocommon.cpp  2
- game/overlord/jakx/ssound.h  1
- game/overlord/jakx/list.cpp  1
- game/overlord/jakx/sbank.cpp  1
- game/overlord/jakx/basefile.h  1
- game/kernel/jakx/kscheme.cpp  98
- game/overlord/jakx/iso_api.cpp  1
- game/kernel/jakx/klink.h  2
- game/overlord/jakx/overlord.h  1
- game/kernel/jakx/kscheme.h  3
- game/overlord/jakx/vblank_handler.cpp  1
- game/kernel/jakx/klink.cpp  55
- game/kernel/jakx/kprint.cpp  22
- game/overlord/jakx/sbank.h  1
- game/overlord/jakx/iso_queue.cpp  3
- game/overlord/jakx/rpc_interface.h  1
- game/overlord/jakx/streamlist.h  1
- game/overlord/jakx/iso_cd.cpp  10
- game/overlord/jakx/dma.h  1
- game/overlord/jakx/vag.h  1
- game/overlord/jakx/iso_api.h  1
- common/util/font/dbs/font_db_jakx.cpp  9

See the complete overview on Codacy

Annotations

Check warning on line 109 in game/kernel/jakx/klisten.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/kernel/jakx/klisten.cpp#L109 

Consecutive return, break, continue, goto or throw statements are unnecessary.

Check warning on line 415 in game/kernel/jakx/kprint.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/kernel/jakx/kprint.cpp#L415 

Casting between unsigned long * and float * which have an incompatible binary data representation.

Check warning on line 1054 in game/kernel/jakx/kscheme.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/kernel/jakx/kscheme.cpp#L1054 

Variable 'new_type_obj->memusage_method.offset' is assigned an expression that holds the same value.

Check warning on line 29 in game/overlord/jakx/basefile.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/basefile.cpp#L29 

Variable 'm_Status' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 33 in game/overlord/jakx/basefile.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/basefile.cpp#L33 

Variable 'm_nNumPages' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 54 in game/overlord/jakx/basefile.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/basefile.cpp#L54 

Variable 'm_Status' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 73 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L73 

Variable 'fifo_entry_sema' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 74 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L74 

Variable 'current_thread_priority' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 75 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L75 

Variable 'disk_type' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 76 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L76 

Variable 'tray_flag' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 78 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L78 

Variable 'event_flag' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 79 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L79 

Variable 'fifo_access_sema' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 80 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L80 

Variable 'tray_flag2' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 81 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L81 

Variable 'initialized' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 82 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L82 

Variable 'm_nNumFifoEntries' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 83 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L83 

Variable 'ring_head' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 84 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L84 

Variable 'ring_tail' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 85 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L85 

Variable 'read_in_progress' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 86 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L86 

Variable 'callback' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 88 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L88 

Variable 'trayflag3' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 89 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L89 

Variable 'm_nDvdThreadAccessSemaCount' is assigned in constructor body. Consider performing initialization in initialization list.

Check warning on line 282 in game/overlord/jakx/dvd_driver.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/dvd_driver.cpp#L282 

Condition 'desc->m_pTail==tail' is always true

Check warning on line 407 in game/overlord/jakx/iso.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/iso.cpp#L407 

Variable 'internal_cmd->status' is reassigned a value before the old one has been used.

Check warning on line 583 in game/overlord/jakx/iso.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/iso.cpp#L583 

Either the condition '!base_file' is redundant or there is possible null pointer dereference: base_file.

Check warning on line 620 in game/overlord/jakx/iso.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

game/overlord/jakx/iso.cpp#L620 

The scope of the variable 'stereo_cmd' can be reduced.
View more details on Codacy Production