Add collision viewer for Jak 1 Custom levels#3813
Draft
Zedb0T wants to merge 1 commit into
Draft
Conversation
water111
reviewed
Jan 5, 2025
| ((-> arg value) | ||
| (false! (-> arg value)) | ||
| (logior! *vu1-enable-user-menu* (vu1-renderer-mask tfrag trans-tfrag tie tie-near)) | ||
| (logior! *vu1-enable-user-menu* (vu1-renderer-mask tfrag tie tie-near)) |
Collaborator
There was a problem hiding this comment.
Why remove trans-tfrag here? Not a big deal either way, just curious.
Contributor
Author
Comment on lines
-1307
to
+1308
| if (bucket_id == 31 - 1 && Gfx::g_global_settings.collision_enable) { | ||
| if (bucket_id == (int)jak1::BucketId::MERC_PRIS_LEVEL0 && | ||
| Gfx::g_global_settings.collision_enable) { |
Collaborator
There was a problem hiding this comment.
I think moving this here will break shadows on the collision geometry but I'm not sure. What if you put GENERIC_ALPHA as the bucket instead?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.