[goal] Support loop unrolling with :unroll factor#3449
Draft
Brent-Hickey wants to merge 3 commits into
Draft
Conversation
xTVaser
requested changes
Aug 18, 2024
Comment on lines
+391
to
+398
| (when (and (integer? limit) | ||
| (> unroll limit) | ||
| ) | ||
| (error ":unroll factor must be <= the loop limit.") | ||
| ) | ||
| (when (< unroll 1) | ||
| (error ":unroll factor must be >= 1.") | ||
| ) |
Member
There was a problem hiding this comment.
For whatever reason, in the original code they left dotimes in that iterate 0 times. This highlights an edge-case with the assumption that every loop will execute atleast once.
See cloth.gc in jak3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this will actually be useful but thought it'd be cool to support
Supports optional loop unrolling with :unroll factor
Supports (_ x) syntax to unroll without binding and incrementing a variable when fully unrolled. Otherwise uses gensym var to iterate.
Could add to countdown as well
Examples:
(unchanged)