Skip to content

fix(login): wait for either 2FA input target in step_two_fa #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Srain021 wants to merge 1 commit into from
Closed

fix(login): wait for either 2FA input target in step_two_fa #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ibeam/src/handlers/login_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,8 +357,15 @@ def step_two_fa(self,
_LOGGER.warning(f'No 2FA code returned. Aborting authentication.')
raise AttemptException(cause='break')
else:
two_fa_input_target = self._find_two_fa_input_target(targets, driver)
two_fa_el, _ = wait_and_identify_trigger(is_clickable(two_fa_input_target), skip_identify=True)
# Wait for either input element — avoids a race where the IBKR SPA
# briefly re-renders between step_select_two_fa detecting the input
# and this call. Letting wait_and_identify_trigger accept either
# target removes the need for a point-in-time DOM snapshot.
two_fa_el, _ = wait_and_identify_trigger(
is_clickable(targets['TWO_FA_INPUT']),
is_clickable(targets['TWO_FA_INPUT_GENERIC']),
skip_identify=True
)

two_fa_el.clear()
two_fa_el.send_keys(two_fa_code)
Expand Down