[DRAFT] feat: allow move child element out side parent#1371
Closed
spartan-vutrannguyen wants to merge 1 commit intomainfrom
Closed
[DRAFT] feat: allow move child element out side parent#1371spartan-vutrannguyen wants to merge 1 commit intomainfrom
spartan-vutrannguyen wants to merge 1 commit intomainfrom
Conversation
| oidToCodeChange, | ||
| ); | ||
| request.structureChanges.push(movedEl); | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
@Kitenite Im facing a problem here, please take a look
Contributor
There was a problem hiding this comment.
Can you explicitly state the problem? I don't have enough context to understand.
Kitenite
reviewed
Feb 15, 2025
| element = element.parentElement; | ||
| } | ||
| } finally { | ||
| draggedElement.style.display = ''; |
Contributor
There was a problem hiding this comment.
This is distructive. The element loses its original display value.
Kitenite
reviewed
Feb 15, 2025
| ): HTMLElement | null { | ||
| draggedElement.style.display = 'none'; | ||
|
|
||
| try { |
Contributor
There was a problem hiding this comment.
This should early return for certain conditions.
- Point is within element
- Point is element
- Target element should not have children (img, input, etc)
Contributor
|
Hello, I am migrating the desktop app to a new repository. This repository will now focus on the web version. This PR has been migrated to the new repository: onlook-dev#22. Sorry for the inconvenience, rest assure your work here will also be adapted for the web version (if it hasn't already). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes