[UPD] website_membership_registration: Add allow registration field for membership groups#144
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new allow_registration flag on membership groups and updates the website membership registration flow to only offer groups that are both published and explicitly allowed for registration.
Changes:
- Add
allow_registrationBoolean field onmembership.group. - Filter membership groups in the website registration controller by
allow_registration = True. - Add a post-migration script to enable registration for already-published groups (and bump module version / load a new view).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website_membership_registration/views/membership_group_view.xml | Adds an inherited form view intended to expose the new allow_registration toggle in the UI. |
| website_membership_registration/models/membership_group.py | Introduces allow_registration Boolean field on membership groups. |
| website_membership_registration/migrations/18.0.1.1.0/post-migrate.py | Sets allow_registration=True for existing published groups during upgrade. |
| website_membership_registration/controllers/main.py | Filters selectable membership groups in registration flow to published + allow_registration. |
| website_membership_registration/manifest.py | Bumps version and includes the new view file in module data. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…or membership groups pre-commit fixes Updates
ByteMeAsap
force-pushed
the
18.0-upd-website_membership_registration
branch
from
52d77b0 to
a1d970a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.