Repository navigation
tests: stub live reachability probe in CLI tests - #102
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RCCNPK29nYpi1g2fypKy4x
|
[Low impact] The PR appears safe to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
mainfailed after #101 (run 41635625122):test_get_non_csv_error_with_brackets_is_escapedprintedECB API unreachable.Cause: CLI commands call
_check_api_reachable, a live GET on the provider base URL, skipped only when a rate-limit file already exists. Locally the file is always there, so the probe never runs; on CI's fresh cache it runs, and a test inheriting the ECB provider from the previous test hit the real ECB. The PR run passed only because ECB answered that time.Fix: autouse fixture in
tests/conftest.pystubs the probe for the whole suite (no test is about it). Five oldersearch --semantictests had the same latent dependency on Eurostat being reachable.Check: sockets blocked + empty cache, as on CI: 6 failed before, 521 passed after. ruff, mypy ok.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RCCNPK29nYpi1g2fypKy4x