Add token request parameters for authorization code flow#192
Closed
coberlin wants to merge 1 commit intoomniauth:masterfrom
Closed
Add token request parameters for authorization code flow#192coberlin wants to merge 1 commit intoomniauth:masterfrom
coberlin wants to merge 1 commit intoomniauth:masterfrom
Conversation
The access token request needs the code if we're using code flow. For authorization code flow, grant_type and redirect_uri are also required. See https://docs.duendesoftware.com/identityserver/v7/reference/endpoints/token/ To run tests, pin the minitest version per a conflict with mocha, as noted here: freerange/mocha#614 But do not leave pinned as the gem fails to install under some rubies that previously succeeded. For example: net-imap-0.5.0 requires ruby version >= 3.1.0, which is incompatible with the current version, ruby 2.6.8p0 (jruby 9.3.7.0)
107f9e3 to
42df4f4
Compare
|
Would be nice to have this merged with one extension:
Then for example also auth0 would be working with this gem. At least in my tests. |
|
@coberlin Maybe you can add this to your changes here. @stanhu @bufferoverflow Any chance that this can be merged? |
Member
|
@dominikklein I miss a test and I think might be worth todo a code suggestion regarding your comment. |
|
Then I will try to add a new PR, with a test :-) |
Author
|
@dominikklein Your PR #199 looks good to me! I'll close my PR. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The access token request needs the code if we're using code flow. For authorization code flow, grant_type and redirect_uri are also required. See https://docs.duendesoftware.com/identityserver/v7/reference/endpoints/token/
To run tests, pin the minitest version per a conflict with mocha, as noted here: freerange/mocha#614
But do not leave pinned as the gem fails to install under some rubies that previously succeeded.
For example:
net-imap-0.5.0 requires ruby version >= 3.1.0, which is incompatible with the current version, ruby 2.6.8p0 (jruby 9.3.7.0)