Skip to content

Security: Improper Error Handling and Silent Failure in Agent Lifecycle #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Security: Improper Error Handling and Silent Failure in Agent Lifecycle #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions cmd/ome-agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,16 @@ func runAgentCommand(cmd *cobra.Command, module AgentModule, action func() error
fx.Hook{
OnStart: func(context.Context) error {
go func() {
if err := action(); err != nil {
l.Error(module.Name()+" encountered an error during execution", zap.Error(err))
os.Exit(1)
}
if err := sh.Shutdown(); err != nil {
l.Error("Failed to shutdown "+module.Name(), zap.Error(err))
}
if err := action(); err != nil {
l.Error(module.Name()+" encountered an error during execution", zap.Error(err))
if err := sh.Shutdown(fx.ExitCode(1)); err != nil {
l.Error("Failed to shutdown "+module.Name(), zap.Error(err))
}
return
}
if err := sh.Shutdown(); err != nil {
l.Error("Failed to shutdown "+module.Name(), zap.Error(err))
}
}()
return nil
},
Expand All @@ -79,8 +82,7 @@ func runAgentCommand(cmd *cobra.Command, module AgentModule, action func() error

app := fx.New(fx.Options(options...))
app.Run()
err := app.Stop(context.Background())
if err != nil {
return
if err := app.Stop(context.Background()); err != nil {
cmd.PrintErrln("Error during shutdown:", err)
}
}
}
Loading