[Core] Add OCI artifact reuse support for ome-agent#665
Open
op109lvb wants to merge 1 commit into
Open
Conversation
op109lvb
requested review from
CatherineSue,
XinyueZhang369,
beiguo218,
davidsnahm,
frankzhouhr,
heymrbox,
pallasathena92,
slin1237 and
speedmancs
as code owners
July 13, 2026 08:36
EdHasNoLife
reviewed
Jul 13, 2026
| EnableSizeLimitCheck: true, | ||
| HFDownloadTimeout: 72 * time.Hour, | ||
| HFDownloadStaleProgressTimeout: 30 * time.Minute, | ||
| ArtifactUploadLockTimeout: 120 * time.Hour, |
Collaborator
Author
There was a problem hiding this comment.
120h is conservative because the existing HF download timeout is 72h and the replication job active deadline is 96h. The lock timeout should be longer than a legitimate long-running job, otherwise a second job could treat an active upload as stale and write to the same OCI Object Storage prefix. It is configurable, so we can lower it from the ConfigMap to unblock if needed.
EdHasNoLife
approved these changes
Jul 15, 2026
frankzhouhr
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds OCI Object Storage artifact reuse support to ome-agent replica flow.
The replica agent now:
Why we need it
Multiple replication jobs can target the same OCI Object Storage artifact prefix. Without coordination, they can upload concurrently and expose partial artifacts to later consumers. The completion marker and active upload lock make reuse safe while preserving legacy behavior unless reuse is explicitly enabled by the replication job.
Fixes #
How to test
Run:
E2E:
Checklist
make testpasses locally