Repository navigation
fix: memcheck's guard-page overhead and three real leaks; add Codecov - #210
Merged
Merged
Conversation
read_to_string's result was never freed across 8 call sites that parse an import's file text standalone.
format()'s vargs unpacking skipped freeing string slots on the assumption they're always borrowed, leaking a caller's heap-built string.
Per-allocation guard pages exceeded a CI runner's memory budget on compile-heavy files; small allocations now share one guarded arena per size class instead.
Also updates docs/tooling.md's codecov-action example to v5 with a token, matching ci-dev.yml.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
fun test .), 56/56fun -fmt-check-allcleanscripts/run_examples.sh, 0 unexpected failuresfun test . -memcheckrun in a Docker container matching CI's spec (ubuntu 24.04 arm64, 16GB RAM/16GB swap cap, 4 CPU), 53/56 - remaining 3 are this stripped container missing git/openssl-dev, confirmed unrelated to memcheck