Conversation
omarchy-hw-fingerprint only proves a reader is present, not that libfprint can drive it. Readers like Goodix TLS-encrypted sensors (27c6:55b4, found on the ThinkPad L13 Yoga Gen 3) or an Elan MOC sensor outside the elanmoc table enumerate on USB but have no libfprint driver at all, so enrollment fails no matter how many times it's retried. Check fprintd-list before attempting enrollment and bail with a clear message when it reports zero devices, instead of sending the user through fprintd-enroll and telling them to try again. Fixes omacom#11841 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SMHmPqFQQroLFtP5t8Athe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omarchy setup security fingerprintsends readers with no libfprint driver at all (e.g. Goodix TLS-encrypted sensors like27c6:55b4on the ThinkPad L13 Yoga Gen 3) throughfprintd-enrolland tells the user to "try again" on failure — advice that can never work, since libfprint has nothing to enroll against.fprintd-list "$USER"check before enrollment. It reliably exits 1 with "No devices available" when libfprint has no driver for the detected reader (verified against fprintd's own source). On that path, print a clear message pointing at the supported-devices list and the Discord instead of attempting enrollment.Test plan
fprintd-liststub and a new case totest/shell.d/fingerprint-package-test.shcovering the zero-driver pathbash test/shell.d/fingerprint-package-test.sh— all 6 cases passbash test/shell(full shell suite) — no new failures; the 5 pre-existing failures (config-test.sh,snapper-test.sh,unowned-system-paths-test.sh,locate-test.sh,bar-widget-contract-test.sh) reproduce identically on a clean checkout with this change stashed out, and are caused by environment setup unrelated to this change (missingOMARCHY_PKGS_PATHcheckout, a stray non-UTF8 file, and one flaky run)27c6:55b4🤖 Generated with Claude Code
https://claude.ai/code/session_01SMHmPqFQQroLFtP5t8Athe