Skip to content

Sync upstream (six-hourly): iptsd 3.1.1-1 - #1397

Open
ryanrhughes wants to merge 1 commit into
masterfrom
auto/sync-upstream-iptsd
Open

ryanrhughes wants to merge 1 commit into
masterfrom
auto/sync-upstream-iptsd

Conversation

@ryanrhughes

@ryanrhughes ryanrhughes commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Automated update of a package that tracks an upstream vendor release
feed or branch tip rather than the AUR.

Release watches and providers are declared in .omarchy/package.json;
exceptional feeds use .omarchy/upstream.sh. This PR auto-merges once
the build checks pass. A failing build leaves it open for a maintainer
without holding back any other package.

@maralcbr maralcbr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryanrhughes. The bump itself is right: 106f944 is upstream's v3.1.1 tag, pkgrel is back to 1, and v3.1.0..v3.1.1 upstream only touches CI, release metadata and the meson wraps, which we don't use because build() passes --wrap-mode=nofallback. The aarch64 build ran for real: both checksums passed and it produced iptsd-3.1.1-1.

self-tests is red, though, and it's required, so this can't auto-merge. Two things stand in the way:

  1. pkgbuilds/iptsd/test.sh:14-15 pins the old commit. It checks _commit == a83bc12… ("pinned v3.1.0 commit"), so it fails at this head and will fail on every future sync. Running it locally gives not ok - iptsd builds from the pinned v3.1.0 commit; with master's PKGBUILD it passes. Please check the shape instead, e.g. [[ $_commit =~ ^[0-9a-f]{40}$ ]] || fail "iptsd builds from a pinned upstream commit", and keep the check at lines 16-17 that the source is fetched at _commit.
  2. The channels key, which isn't this PR's fault. CI actually stops earlier, in tests/package-metadata.sh: invalid channels for iptsd ... invalid channels for surface-snapdragon-addresses: channels is gone (helpers/package-metadata.sh:488-491). Both packages landed (#826, #972) with "channels": ["edge"] after 61ff008 retired the key, and the test validates every package, so master's self-tests fails the same way and every package PR is blocked by it. That's also why the test.sh failure above doesn't show in CI yet. Could someone drop channels from both package.json files in a separate PR on master? It's already ignored for routing, so nothing changes in where either package publishes.

Smaller thing:

  • pkgbuilds/iptsd/README.package.md:3 still says v3.1.0. Suggest version-neutral wording, "built from a pinned upstream release of linux-surface/iptsd", so syncs don't leave it stale. It's installed by the package, so the second entry in sha256sums needs updating with it.

With the test.sh fix in and master's channels fix landed, this is good to merge from my side.

@ryanrhughes
ryanrhughes force-pushed the auto/sync-upstream-iptsd branch 6 times, most recently from 377f6e7 to b98670e Compare October 22, 2026 17:22
@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The update reaches users of one aarch64 Surface digitizer package.

The PR is not ready to merge because test.sh still rejects the new upstream commit.

Findings

  1. P1 New pin breaks CI ▶
  2. P2 Documentation names the old release ▶

Summary

Updates iptsd from 3.1.0-2 to 3.1.1-1.

  • The Surface digitizer package now builds iptsd 3.1.1.

Reviews (41) · Last reviewed commit: "Sync upstream (six-hourly): iptsd 3.1.1-..." · Reviewed by Greptile

Comment thread pkgbuilds/iptsd/PKGBUILD
pkgname=iptsd
pkgver=3.1.0
pkgrel=2
pkgver=3.1.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Documentation names the old release

The package now uses v3.1.1, but the installed README.package.md still says it was built from v3.1.0. That mismatch can confuse bug reports. Update the document's version reference and refresh its checksum in PKGBUILD.

@ryanrhughes
ryanrhughes force-pushed the auto/sync-upstream-iptsd branch from b98670e to 5686881 Compare October 22, 2026 21:47
Comment thread pkgbuilds/iptsd/PKGBUILD
makedepends=('cli11' 'cmake' 'eigen' 'git' 'meson' 'microsoft-gsl' 'ninja')
options=('!debug')
_commit=a83bc1232f7096f8b33b50fdbda249cd640de670
_commit=106f944ac097f8eb779bdfee0487d58ae853c375

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 New pin breaks CI

test.sh sources this PKGBUILD but still requires _commit to equal a83bc1232f7096f8b33b50fdbda249cd640de670. The new value fails that check and makes the test exit with an error. The PR workflow runs this test, so its self-tests job will fail.

Update the test to match the new release or check the pin without hardcoding the old release.

@ryanrhughes
ryanrhughes force-pushed the auto/sync-upstream-iptsd branch 3 times, most recently from d08d402 to 3c359ed Compare October 23, 2026 17:19
@ryanrhughes ryanrhughes changed the title Sync upstream releases: iptsd 3.1.1-1 Sync upstream (six-hourly): iptsd 3.1.1-1 Oct 23, 2026
@ryanrhughes
ryanrhughes force-pushed the auto/sync-upstream-iptsd branch 13 times, most recently from ab23bbb to edd8825 Compare October 27, 2026 00:21
@ryanrhughes
ryanrhughes force-pushed the auto/sync-upstream-iptsd branch 7 times, most recently from 38529b8 to 8ce133f Compare October 30, 2026 12:22

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile has paused reviews on this repository — it used its 750 free open-source review credits for this billing period. Reviews resume automatically on November 21. To continue before then, an organization admin can keep reviews running past the free credits — those bill as normal usage.

@ryanrhughes
ryanrhughes force-pushed the auto/sync-upstream-iptsd branch 20 times, most recently from 19acacb to 634339f Compare November 4, 2026 12:22
@ryanrhughes
ryanrhughes force-pushed the auto/sync-upstream-iptsd branch from 634339f to c1b2940 Compare November 4, 2026 18:22

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants