Skip to content

Skip the Electron wrapping on a runtime without its helpers - #23

Merged
maralcbr merged 1 commit into
mainfrom
electron-wrap-optional
Oct 10, 2026
Merged

maralcbr merged 1 commit into
mainfrom
electron-wrap-optional

Conversation

@maralcbr

@maralcbr maralcbr commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Converge omarchy-mac and omarchy-mx-mac into upstream Omarchy omarchy#14431 moved omarchy-cmd-electron-gl-wrap and omarchy-cmd-desktop-exec-repair to their own change (Run 1Password with software GL where there is no render GPU omarchy#14717). lib/electron-launchers and lib/electron-desktop-entries still called them whenever Chromium was installed, so omarchy-provision-hardware exited 127 on every first boot (Mac VM run of the merged #14431).
  • System setup skips when the runtime has no wrapper; user setup skips when it lacks either helper. Existing wrappers stay (they become pass-through without the runtime's GL-args helper). With both helpers present nothing changes.
  • CI's runtime pin moves to #14431's head 5397950a2 (the old pin predated the move, which is why CI missed it). That head's owner setup enrolls USB and Thunderbolt accessories, so provision-owner-luks-test.sh gains stubs for both.
  • omarchy-mac 0.1.1. README, ORIGINS and the on-disk manual page say when the wrapping applies.

Test plan

  • omarchy-mac/test/all, omarchy-mac-boot/test/all, test/integration/all, scope and architecture gates pass in an Arch container against 5397950a2
  • Electron integration test against the previous runtime 4d9bdc49d too, including the new wrapper-without-repair case
  • Grok 4.7 xhigh and GPT 6 Astra reviews: no bugs, no maintainer opt-in; version bump, mixed-helper test and doc wording they asked for are in
  • CI

@maralcbr
maralcbr requested a review from scottjones as a code owner October 9, 2026 23:57
#14431 moved omarchy-cmd-electron-gl-wrap and omarchy-cmd-desktop-exec-repair
to their own change (#14717), so platform setup exited 127 on every boot of a
Mac with Chromium. System setup now skips when the runtime has no wrapper, and
user setup when it lacks either helper; existing wrappers stay. CI follows
#14431's head, which also needs stubs for owner setup's accessory enrollment.
omarchy-mac 0.1.1.
@maralcbr
maralcbr force-pushed the electron-wrap-optional branch from 03dc197 to da89bc2 Compare October 10, 2026 00:02
@maralcbr
maralcbr merged commit b2c3985 into main Oct 10, 2026
7 checks passed
scottjones added a commit that referenced this pull request Oct 10, 2026
Brings in #23. omarchy-mac stays at #12's 0.2.0 over main's 0.1.1, in
the version file and the README. The runtime pin moves to
omacom/omarchy#14675's head 00fcc451, the fingerprint-readers detector
on quattro, since f317ea50 is no longer any PR's head. Quattro renames
the platform from apple-silicon to aarch64-apple, so the platform-name
tests need #24 before this pin passes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant