Repository navigation
Read #14431's renamed Apple package list and pacman templates - #51
Open
ryanrhughes wants to merge 1 commit into
Open
ryanrhughes wants to merge 1 commit into
ryanrhughes wants to merge 1 commit into
Conversation
omacom/omarchy#14431 renames the Apple Silicon platform to aarch64-apple, moving its package list to install/omarchy-aarch64-apple.packages and its pacman templates to default/pacman/aarch64-apple/. The image builder and its inspection now take those first, and still take a candidate set's older runtime's omarchy-apple-silicon.packages or omarchy-apple.packages and its apple-silicon or aarch64 templates. The image still says platform=apple-silicon: the renamed runtime reads that as aarch64-apple, and older runtimes know only that name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omacom/omarchy#14431 renames the platforms to
x86,aarch64andaarch64-apple. For the image builder that moves two runtime paths it reads directly:install/omarchy-apple-silicon.packages→install/omarchy-aarch64-apple.packagesdefault/pacman/apple-silicon/→default/pacman/aarch64-apple/Without this,
build-mac-imagestops with "the runtime ships no Apple package list" on any candidate set built from the renamed runtime.What changes
build-mac-image,builder/candidate_set.pyandbuilder/inspection.pytake the new list and template first, then fall back to the older names, so candidate sets from older runtimes still build and inspect.IMAGEstill sayplatform=apple-silicon. The renamed runtime reads that asaarch64-apple, older runtimes only know that name, and release names and the installer app key off it. Switching the manifest toaarch64-applecan come once no supported candidate set predates the rename.aarch64-appletemplate winning in inspection.docs/image-producer.mdname the new paths.Testing
image-builder/test/allpasses (Arch x86_64 host): syntax and compile checks,test_candidate_set.py,test_inspection.py,test_mac_image_check.py,test_lab_access.pyand the shell tests.Companion: omacom/omarchy-mac-pkgs#24. Merge both before #14431.