Repository navigation
Say Not supported only for a Mac model the installer refuses - #44
Merged
scottjones merged 1 commit intoOct 8, 2026
Merged
scottjones merged 1 commit into
scottjones merged 1 commit into
Conversation
On a 14-inch M2 Max (apple,j414c, enabled in the signed edge catalog) installer 2.0.10 showed APPLE M2 MAX · 426 GB FREE · NOT SUPPORTED because an older Omarchy install was still on the disk. The header badged every existing-install page and every stop before the welcome page as Not supported, including too little space and an engine that couldn't run. The same Mac read SUPPORTED as soon as the old install was removed. The session now decides the badge. Not supported means the model was refused (blocked, or missing from the catalog). An existing install or too little space on a supported Mac says Supported, and a stop where the installer couldn't tell shows no support badge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshuaswarren
marked this pull request as ready for review
October 6, 2026 18:01
scottjones
approved these changes
Oct 8, 2026
scottjones
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed and verified locally on macOS: swift-format lint --strict is clean, and all 59 InstallerSessionTests pass, including testHeaderSaysNotSupportedOnlyForARefusedModel. It also matches what I saw on an M3 Air: Not supported over an existing install, then Supported after removing it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header says Not supported only when the installer refuses the Mac model.
What happened
On a 14-inch M2 Max (apple,j414c,
status: enabledin the signed edge catalog) installer 2.0.10 showedAPPLE M2 MAX · 426 GB FREE · NOT SUPPORTED · EDGEabove "Omarchy is already installed". The only problem was an older install still on the disk. After Remove Omarchy, the same Mac showed SUPPORTED.On main the header still badges every
.existingInstallRefusedand every.unsupportedpage as Not supported. That includes too little space and a Mac the installer couldn't inspect.Change
InstallerSession.modelSupporteddecides the badge. It isfalseonly for a refused model (isBlockedModel: blocked, or missing from the catalog). An existing install or a space shortfall on a supported Mac givestrue. A stop where the installer couldn't tell givesnil, and the header shows no support badge.OnePageInstallerViewrenders that value. Its privateisBlockedis removed.Tests
testHeaderSaysNotSupportedOnlyForARefusedModelchecks 7 cases. With the old rule moved into the session unchanged, 4 fail: existing install on a supported Mac, existing install where the engine couldn't tell, too little space, and not ready. With this change all 7 pass.Run on an M1 Ultra Mac Studio (Mac13,2), macOS 26.6.2, Xcode 27.0, Swift 6.4:
xcrun swift-format lint --strict --recursive Package.swift Sources Tests: cleanswift test: 148 + 3 + 519 + 8 tests, 0 failures (1 existing skip)swift test -c release: 137 + 3 + 519 + 5 tests, 0 failures./test/allon Linux: passedI didn't capture a screenshot of the new header on a Mac with an existing install.