-
Notifications
You must be signed in to change notification settings - Fork 3
Replace hapi with hono #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 71 commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
ffde8e0
Report version from manifest
corrideat cbee166
Updates
corrideat 93eba67
build
corrideat 42f1425
Use hono for the API
corrideat 4982946
Add endpoint tests
corrideat e020978
Merge branch 'serve-api-unit-tests' into replace-hapi-with-hono
corrideat a8d2ef2
Fixes
corrideat 88d2651
Fix build step
corrideat a489c8d
Fix incorrect JSON parsing
corrideat ecff1d9
Improve tests
corrideat 64cf74e
Improvements
corrideat 80765de
Remove --sloppy-imports
corrideat edbf14e
Remove redundant call
corrideat 3aaa5fb
Clean up on shutdown
corrideat eea4b60
Update AGENTS.md
corrideat 5f658c7
No private API use
corrideat 0670392
Partially revert
corrideat 9f95cc8
Build artifacts
corrideat 62475e1
Merge branch 'serve-api-unit-tests' into replace-hapi-with-hono
corrideat ba080fb
Feedback
corrideat 1f4a528
Feedback
corrideat 4ad9ee8
Updates
corrideat c8a9209
Avoid `/g` for clarity
corrideat 5239115
Updates
corrideat 9a84046
Use separate regexes
corrideat 7b47db4
Merge branch 'version-from-manifest' into replace-hapi-with-hono
corrideat 82aa9da
Merge remote-tracking branch 'origin/serve-api-unit-tests' into repla…
corrideat d9b1488
Feedback
corrideat 37c2927
Refinements
corrideat 5a82a2d
Further simplifications
corrideat 79bcf01
async-ready server lifecycle
corrideat 5eb98e1
Fixes
corrideat 0679f6c
Feedback
corrideat b220cc0
Feedback
corrideat 8219614
Build
corrideat 07da7a7
Fix tests
corrideat 312bbe6
Merge branch 'serve-api-unit-tests' into replace-hapi-with-hono
corrideat e5c8b75
Add character set validation
corrideat 3d63efc
Merge branch 'serve-api-unit-tests' into replace-hapi-with-hono
corrideat 1976411
Update return types
corrideat a925f54
Feedback
corrideat 8b4b325
build
corrideat ede943f
Change name for consistency
corrideat 6a40a04
Update README.md
corrideat b78b26e
Fixes
corrideat 7e432ec
Fix example
corrideat 740ec9b
Fixes
corrideat 5575ac7
Merge branch 'version-from-manifest' into replace-hapi-with-hono
corrideat 11670f3
Merge branch 'serve-api-unit-tests' into replace-hapi-with-hono
corrideat 8ba8a28
Merge branch 'master' into replace-hapi-with-hono
corrideat dd2571b
Improvements
corrideat 6b1317d
Feedback
corrideat e33f433
Feedback
corrideat fb6fa01
lint
corrideat db9d982
Fixes
corrideat ac7c33d
Feedback
corrideat 6b203be
Remove proxy compat
corrideat 33514a5
Fixes
corrideat b244527
Remove new `.parse()`
corrideat 4835d49
Review
corrideat 2d78852
DB init/close improvements
corrideat 725cf76
DB improvements
corrideat d6bc4c6
Various fixes:
corrideat a714cc5
Feedback
corrideat 000902c
Feedback
corrideat eb29cdc
Fix missing `chel` and added `.gitignore` for a more permanent fix.
corrideat e95c9e6
Protect chel
corrideat 43b1949
[bin-update]
corrideat c0c39b9
Review
corrideat d9dd908
Simplify error handling
corrideat 6c8f2eb
lint
corrideat af04bcc
fixes
corrideat 64f18e6
Feedback
corrideat 53c62a6
Indentation
corrideat e2b0bd6
dist
corrideat 040f7d0
Fixes
corrideat 9f97ba4
feedback
corrideat af3566d
Feedback
corrideat 348983e
Feedback
corrideat bbe963f
db refs
corrideat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: Reject protected-dir changes | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "master" ] | ||
| pull_request: | ||
| branches: [ "master" ] | ||
|
|
||
| jobs: | ||
| reject-protected: | ||
| runs-on: ubuntu-slim | ||
| env: | ||
| PROTECTED_DIR: bin/ | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Fail if protected dir changed (unless [bin-update] present) | ||
| run: | | ||
| BASE_REF="${{ github.event.pull_request.base.ref }}" | ||
| # fetch base for diff/log | ||
| git fetch origin "$BASE_REF" --depth=1 | ||
|
corrideat marked this conversation as resolved.
|
||
|
|
||
| # if any commit message includes [bin-update], skip the check | ||
| if git log --pretty=%B "origin/${BASE_REF}"..HEAD | grep -q '\[bin-update\]'; then | ||
| echo "Bypass: a commit message contains [bin-update]." | ||
| exit 0 | ||
| fi | ||
|
|
||
| # list changed files between PR branch and base | ||
| changes=$(git diff --name-only "origin/${BASE_REF}"..HEAD || true) | ||
|
|
||
| # fail if any changed file is under the protected directory | ||
| if echo "$changes" | grep -E "^${PROTECTED_DIR}"; then | ||
| echo "ERROR: Changes detected under ${PROTECTED_DIR}. Rejecting PR." | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "No changes detected under ${PROTECTED_DIR}." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Until we implement <https://github.com/okTurtles/chel/issues/125>, the files | ||
| # in this directory must _not_ be version-controlled, as they're placeholders | ||
| # used by the post install script. However, running `npm install` on this | ||
| # project will result in overwriting the file if the post install script runs | ||
| # To avoid this, all files under this directory are ignored. | ||
| * |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| placeholder, will be replaced by real binary. DO NOT DELETE THIS FILE! |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.