Skip to content

fix: handle missing appointment success data #16692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
musammilvilayil wants to merge 2 commits into from
+47 −5
Closed

fix: handle missing appointment success data #16692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
591ad8c
fix appointment success error state
musammilvilayil Aug 15, 2026
4eadce1
fix: refine appointment success error states
musammilvilayil Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 47 additions & 5 deletions src/pages/PublicAppointments/Success.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
import { useQuery } from "@tanstack/react-query";
import { format } from "date-fns";
import { navigate } from "raviger";
import { useEffect } from "react";
import { useTranslation } from "react-i18next";
import { toast } from "sonner";

import CareIcon from "@/CAREUI/icons/CareIcon";

import Loading from "@/components/Common/Loading";
import { Button } from "@/components/ui/button";

import { usePatientContext } from "@/hooks/usePatientUser";

Expand Down Expand Up @@ -33,18 +36,57 @@ export function AppointmentSuccess(props: { appointmentId: string }) {
enabled: !!tokenData.token,
});

if (error) {
toast.error(t("appointment_not_found"));
}
useEffect(() => {
if (error) {
toast.error(t("page_load_error"), {
id: "appointment-success-load-error",
});
}
}, [error, t]);
Comment thread
musammilvilayil marked this conversation as resolved.

const appointmentData = data?.results.find(
(appointment) => appointment.id === appointmentId,
);

if (isLoading || !appointmentData) {
if (isLoading) {
return <Loading />;
}

if (error) {
return (
<div className="mx-auto flex max-w-3xl flex-col items-center justify-center gap-4 p-12 text-center">
<div
aria-hidden="true"
className="inline-flex size-16 items-center justify-center rounded-full bg-red-100"
>
<CareIcon icon="l-exclamation-circle" className="size-8 text-red-600" />
</div>
<h1 className="text-xl font-medium text-gray-900">
{t("page_load_error")}
</h1>
<p className="text-sm text-gray-600">{t("could_not_load_page")}</p>
<Button onClick={() => navigate("/patient/home")}>{t("home")}</Button>
</div>
);
}

if (!appointmentData) {
return (
<div className="mx-auto flex max-w-3xl flex-col items-center justify-center gap-4 p-12 text-center">
<div
aria-hidden="true"
className="inline-flex size-16 items-center justify-center rounded-full bg-red-100"
>
<CareIcon icon="l-exclamation-circle" className="size-8 text-red-600" />
</div>
<h1 className="text-xl font-medium text-gray-900">
{t("appointment_not_found")}
</h1>
<Button onClick={() => navigate("/patient/home")}>{t("home")}</Button>
</div>
);
}

const appointmentTime = appointmentData.token_slot.start_datetime;
const appointmentDate = format(appointmentTime, "do MMMM");
const appointmentTimeSlot = format(appointmentTime, "hh:mm a");
Expand Down Expand Up @@ -73,7 +115,7 @@ export function AppointmentSuccess(props: { appointmentId: string }) {
<h2 className="text-sm font-medium text-gray-500 mb-1">
{t("patient")}:
</h2>
<p className="text-lg font-medium">{appointmentData?.patient.name}</p>
<p className="text-lg font-medium">{appointmentData.patient.name}</p>
</div>

<div>
Expand Down
Loading