-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CCN beckn referral #16676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
CCN beckn referral #16676
Changes from 45 commits
79ad661
605f469
8352e5c
461d81e
70afec5
9a562b1
756c054
da12f46
a5d9117
5b375f8
6db94da
d459856
b6d4af4
1d120d8
49d6cb6
c2617c6
14a48c0
d3aec31
a3bcd11
725cf45
e276f62
e241601
e8138b3
2ca3b42
90fd169
d46c1c7
67cc426
9325d81
8643c31
d8c2751
b2d5897
b515fef
2bee677
31afc7e
1defbe1
d890e5e
707a921
1a1f5b9
55b8d44
dfd4283
228c53a
7c07e06
077ca16
ddafc71
8ddd2de
9fedb06
9051ab6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ HEADERS="Strict-Transport-Security: max-age=31536000; includeSubDomains; preload | |
| REACT_RECAPTCHA_SITE_KEY=6LcedK8qAAAAAM2PpuqlqhZUxQpmIqHqluL74dDs | ||
|
|
||
| # Care API URL without the /api prefix | ||
| REACT_CARE_API_URL=https://careapi.ohc.network | ||
| REACT_CARE_API_URL=https://develop-api.ohc.network | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Committing the develop API URL into the shared There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pointing the committed default API URL at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Committing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Committing |
||
| REACT_SBOM_BASE_URL=https://sbom.ohc.network | ||
|
Comment on lines
11
to
13
|
||
|
|
||
| # Default payment terms for invoices | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Do not merge the committed API base URL change.
REACT_CARE_API_URLis the committed default for every developer environment and for the test setup.care.config.tsline 50 returns it as the API base URL for all frontend requests, andtests/globalSetup.ts,tests/helper/utils.ts, andtests/setup/questionnaire.setup.tsall read it.Changing it to
https://develop-api.ohc.networkrepoints every local run and every CI run at the develop backend.The PR objectives state that the CCN flow requires a backend with the Beckn BAP module enabled, so the change is understandable for the branch preview. Keep it out of the merged diff. Set the value through the deployment environment or a local
.env.localoverride instead.As per coding guidelines: "Check corresponding backend endpoint in the care backend repo and update both repos if API changes are needed."
🤖 Prompt for AI Agents
Source: Learnings