Skip to content

Compiler, Runtime: initial support for OCaml 5.5#2195

Draft
hhugo wants to merge 2 commits intomasterfrom
ocaml55
Draft

Compiler, Runtime: initial support for OCaml 5.5#2195
hhugo wants to merge 2 commits intomasterfrom
ocaml55

Conversation

@hhugo
Copy link
Copy Markdown
Member

@hhugo hhugo commented Mar 7, 2026

No description provided.

@hhugo
Copy link
Copy Markdown
Member Author

hhugo commented Mar 9, 2026

@vouillon, can you check the failure below.

see https://github.com/ocsigen/js_of_ocaml/actions/runs/22852044514/job/66282725911?pr=2195

Run opam exec -- dune build @runtest-wasm
File "compiler/tests-ocaml/lib-int/dune", line 2, characters 8-12:
2 |  (names test)
            ^^^^
(cd _build/default/compiler/tests-ocaml/lib-int && ../../../.bin/node test.bc.wasm.js) > _build/default/compiler/tests-ocaml/lib-int/test.bc.wasm.js.output
Fatal error: exception File "compiler/tests-ocaml/lib-int/test.ml", line 43, characters 6-12: Assertion failed

@hhugo hhugo force-pushed the ocaml55 branch 2 times, most recently from 3ee1415 to b85ff80 Compare March 9, 2026 16:20
vouillon
vouillon reviewed Mar 10, 2026
View reviewed changes
Comment thread compiler/lib/parse_bytecode.ml Outdated
hhugo
hhugo commented Mar 10, 2026
View reviewed changes
Comment thread compiler/tests-ocaml/match-exception/streams.ml
assert false
;;

let () = test_iter_stream ()
Copy link
Copy Markdown
Member Author

@hhugo hhugo Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this diff about ?

Copy link
Copy Markdown
Member

@vouillon vouillon Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get a memory leak if we don't put the code in its own function since the head of the stream remains live.

@hhugo
Copy link
Copy Markdown
Member Author

hhugo commented Mar 10, 2026

@kit-ty-kate, you can update your alpha opam repo with the tip of this PR.

@hhugo hhugo force-pushed the ocaml55 branch 2 times, most recently from 5c40c3b to 0db9466 Compare March 10, 2026 10:46
@hhugo hhugo changed the base branch from master to ocaml55-now March 10, 2026 10:50
Base automatically changed from ocaml55-now to master March 12, 2026 12:32
@kit-ty-kate
Copy link
Copy Markdown
Contributor

kit-ty-kate commented Mar 18, 2026

@kit-ty-kate, you can update your alpha opam repo with the tip of this PR.

done

@hhugo hhugo force-pushed the ocaml55 branch 3 times, most recently from 218e9de to 8df204b Compare March 30, 2026 14:29
@hhugo hhugo force-pushed the ocaml55 branch 2 times, most recently from d75ea01 to 61284ba Compare April 27, 2026 19:58
@hhugo hhugo changed the base branch from master to ocaml55-now April 28, 2026 08:43
Base automatically changed from ocaml55-now to master April 28, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vouillon vouillon vouillon left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hhugo @kit-ty-kate @vouillon