test: regression baseline for (modules ...) cmi glob over-invalidation#14585
Open
robinbb wants to merge 1 commit into
Open
test: regression baseline for (modules ...) cmi glob over-invalidation#14585robinbb wants to merge 1 commit into
robinbb wants to merge 1 commit into
Conversation
robinbb
force-pushed
the
robinbb-test-unwrapped-explicit-modules-baseline
branch
2 times, most recently
from
0912f61 to
b0c7151
Compare
robinbb
force-pushed
the
robinbb-test-unwrapped-explicit-modules-baseline
branch
from
b0c7151 to
203d9c3
Compare
Pins today's behaviour for a `(wrapped false)` library with an explicit `(modules a b)` clause: editing one sibling's `.mli` rebuilds every sibling's compile rule because the consumer's compile depends on the lib's whole-objdir `.cmi` glob. The test asserts (via `dune trace cat` + `jq`) the rebuild lists explicitly. The forthcoming per-module narrowing work (#14492) will flip both expected outputs to `[]` (sibling rebuilds suppressed by per-module deps). Matches the exact lib shape raised in #14492's review feedback; the explicit `(modules ...)` clause routes through a different parse path from the implicit form covered by `lib-to-lib-unwrapped.t`, so a separate observational test pins the equivalence empirically. Signed-off-by: Robin Bate Boerop <me@robinbb.com>
robinbb
force-pushed
the
robinbb-test-unwrapped-explicit-modules-baseline
branch
from
203d9c3 to
5231a1a
Compare
There was a problem hiding this comment.
Pull request overview
Adds a blackbox regression test that pins current over-invalidation behavior for (wrapped false) libraries with explicit (modules ...), providing a baseline for forthcoming per-module dependency narrowing.
Changes:
- Creates an explicit-module unwrapped library and a sibling consumer library.
- Asserts current wide
.cmiglob dependencies viadune rules. - Verifies unrelated consumer modules rebuild after sibling
.mliedits.
Collaborator
Author
|
@Alizter This is test code factored out of the stack for PR 14492. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins today's behaviour for a
(wrapped false)library with an explicit(modules a b)clause: editing one sibling's.mlirebuilds every sibling's compile rule because the consumer's compile depends on the lib's whole-objdir.cmiglob.The test asserts (via
dune trace cat+jq) the rebuild lists explicitly. The forthcoming per-module narrowing work (#14492) will flip both expected outputs to[](sibling rebuilds suppressed by per-module deps).Matches the exact lib shape raised in #14492's review feedback; the explicit
(modules ...)clause routes through a different parse path from the implicit form covered bylib-to-lib-unwrapped.t, so a separate observational test pins the equivalence empirically.