utils.pwsh: Fix conditional expression#310
Open
RytoEX wants to merge 1 commit intoobsproject:masterfrom
Open
Conversation
Currently, this conditional always evaluates to true. It seems that the intent was to skip Install-Dependencies if either SkipAll or SkipDeps was specified. Fix the conditional logic to reflect that.
d8027c4 to
32ce480
Compare
Member
Author
|
After the initial CI failures, I noticed that this was a bit more nuanced than a simple replacement. The intent seems to be to skip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a conditional expression in utils.pwsh/Setup-Host.ps1.
Motivation and Context
Fixes #307.
How Has This Been Tested?
Tested locally in PowerShell with simple if statements.
Outputs
true.Does not output anything.
Types of changes
Checklist: