Conversation
Fil
left a comment
There was a problem hiding this comment.
I've tested this together with #2143 and it works well.
The ramp opacity legend, which is currently based on d3.rgb, does not support CSS4 color strings; solvable with a SVG filter.
SSR (and snapshot tests) do not work when the colors are defined using a CSS4 string such as color(display-p3 1 0 0). Using a CSS4 color string parser would solve this, but I don't think it's a blocker. I'll add a test that is not "all black".
Here's how it looks: on the left, the test as it runs in the browser with everything p3; on the right, the snapshot test (in dull sRGB).
Are you saying this is a limitation of Plot? Or a limitation of the node-canvas library we are using for snapshot testing? I don’t think that node-canvas supports |
|
Also, are you aware that this is generally slower than the previous implementation?
|
|
Superseded by #2417. |
Alternative to #2414 and #2145; bypass color parsing and color space conversion entirely by using context.fillRect to set colors. Unblocks #2143.