Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export * from "./legends.js";
export * from "./mark.js";
export * from "./marker.js";
export * from "./marks/area.js";
export * from "./marks/areaLine.js";
export * from "./marks/arrow.js";
export * from "./marks/auto.js";
export * from "./marks/axis.js";
Expand Down
1 change: 1 addition & 0 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Mark.prototype.plot = function ({marks = [], ...options} = {}) {
export {plot} from "./plot.js";
export {Mark, marks} from "./mark.js";
export {Area, area, areaX, areaY} from "./marks/area.js";
export {AreaLine, areaLineX, areaLineY} from "./marks/areaLine.js";
export {Arrow, arrow} from "./marks/arrow.js";
export {auto, autoSpec} from "./marks/auto.js";
export {axisX, axisY, axisFx, axisFy, gridX, gridY, gridFx, gridFy} from "./marks/axis.js";
Expand Down
5 changes: 5 additions & 0 deletions src/mark.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,11 @@ export interface MarkOptions {
channels?: Record<string, Channel | ChannelValue>;
}

export interface ColorOptions {
/** Shorthand for setting both the fill and the stroke. */
color?: ChannelValueSpec;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be supported on all marks…

Copy link
Copy Markdown
Contributor

@Fil Fil Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we support color, we'll often want to use this over stroke or fill, because it's less cognitive work—so it should "just work" everywhere.

I feel it can be a bit tricky though, because it might not make sense for all marks to set both stroke and fill. For instance, I don't think we'd want to set a fill on a line (it's rarely a good idea), or a link (it doesn't apply, so better stick with fill: "none"), but maybe on an arrow (it can apply if there is a non-zero bend), although I would rarely do it.

In this sense "color" should mean "the base color for the mark" rather than "a shorthand for stroke and fill".

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the simpler definition of shorthand is easier to understand (and worse is better) and we shouldn’t try to define a “base color” separately for each mark.

I can remove the color shorthand from this PR if you think it’s a bad idea and we can discuss it later.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please remove it, I think it might set the wrong expectation

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it’s worth we already support a color option on the following marks: axis, grid, auto, crosshair, bollinger. The definition I am using here feels consistent with that existing usage.

}

/** The abstract base class for Mark implementations. */
export class Mark {
/**
Expand Down
4 changes: 2 additions & 2 deletions src/marks/area.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {groupIndex} from "../style.js";
import {maybeDenseIntervalX, maybeDenseIntervalY} from "../transforms/bin.js";
import {maybeStackX, maybeStackY} from "../transforms/stack.js";

const defaults = {
const areaDefaults = {
ariaLabel: "area",
strokeWidth: 1,
strokeLinecap: "round",
Expand All @@ -17,7 +17,7 @@ const defaults = {
};

export class Area extends Mark {
constructor(data, options = {}) {
constructor(data, options = {}, defaults = areaDefaults) {
const {x1, y1, x2, y2, z, curve, tension} = options;
super(
data,
Expand Down
40 changes: 40 additions & 0 deletions src/marks/areaLine.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import type {ColorOptions, Data} from "../mark.js";
import {MarkerOptions} from "../marker.js";
import {Area, AreaXOptions, AreaYOptions} from "./area.js";

/** Options for the areaLineX mark. */
export interface AreaLineXOptions extends AreaXOptions, ColorOptions, MarkerOptions {}

/** Options for the areaLineY mark. */
export interface AreaLineYOptions extends AreaYOptions, ColorOptions, MarkerOptions {}

/**
* Returns a new vertically-oriented arealine mark for the given *data* and
* *options*, where the baseline and topline share **y** values, as in a
* time-series area chart where time goes up↑. For example, to plot Apple’s
* daily stock price:
*
* ```js
* Plot.areaLineX(aapl, {y: "Date", x: "Close"})
* ```
*
* See Plot.areaX for more details.
*/
export function areaLineX(data?: Data, options?: AreaLineXOptions): AreaLine;

/**
* Returns a new horizontally-oriented arealine mark for the given *data* and
* *options*, where the baseline and topline share **x** values, as in a
* time-series area chart where time goes right→. For example, to plot Apple’s
* daily stock price:
*
* ```js
* Plot.areaLineY(aapl, {x: "Date", y: "Close"})
* ```
*
* See Plot.areaLineY for more details.
*/
export function areaLineY(data?: Data, options?: AreaLineYOptions): AreaLine;

/** The arealine mark. */
export class AreaLine extends Area {}
80 changes: 80 additions & 0 deletions src/marks/areaLine.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
import {area as shapeArea, line as shapeLine} from "d3";
import {Area} from "./area.js";
import {create} from "../context.js";
import {applyGroupedMarkers, markers} from "../marker.js";
import {applyDirectStyles, applyIndirectStyles, applyTransform, applyGroupedChannelStyles} from "../style.js";
import {groupIndex} from "../style.js";
import {maybeDenseIntervalX, maybeDenseIntervalY} from "../transforms/bin.js";
import {maybeStackX, maybeStackY} from "../transforms/stack.js";

const defaults = {
ariaLabel: "area-line",
fillOpacity: 0.1,
stroke: "currentColor",
strokeWidth: 1.5,
strokeLinecap: "round",
strokeLinejoin: "round",
strokeMiterlimit: 1
};

export class AreaLine extends Area {
constructor(data, options = {}) {
super(data, options, defaults);
markers(this, options);
}
render(index, scales, channels, dimensions, context) {
const {x1: X1, y1: Y1, x2: X2 = X1, y2: Y2 = Y1} = channels;
return create("svg:g", context)
.call(applyIndirectStyles, this, dimensions, context)
.call(applyTransform, this, scales, 0, 0)
.call((g) =>
g
.selectAll()
.data(groupIndex(index, [X1, Y1, X2, Y2], this, channels))
.enter()
.append("g")
.call(applyDirectStyles, this)
.call(applyGroupedChannelStyles, this, channels)
.call((e) =>
e
.append("path")
.attr("stroke", "none")
.attr(
"d",
shapeArea()
.curve(this.curve)
.defined((i) => i >= 0)
.x0((i) => X1[i])
.y0((i) => Y1[i])
.x1((i) => X2[i])
.y1((i) => Y2[i])
)
)
.call((e) =>
e
.append("path")
.call(applyGroupedMarkers, this, channels, context)
.attr("fill", "none")
.attr(
"d",
shapeLine()
.curve(this.curve)
.defined((i) => i >= 0)
.x((i) => X2[i])
.y((i) => Y2[i])
)
)
)
.node();
}
}

export function areaLineX(data, options) {
const {x, y, color, stroke = color, fill = color, z = x === fill || x === stroke ? null : undefined, ...rest} = maybeDenseIntervalY(options); // prettier-ignore
return new AreaLine(data, maybeStackX({...rest, x, y1: y, y2: undefined, z, fill, stroke}));
}

export function areaLineY(data, options) {
const {x, y, color, stroke = color, fill = color, z = y === fill || y === stroke ? null : undefined, ...rest} = maybeDenseIntervalX(options); // prettier-ignore
return new AreaLine(data, maybeStackY({...rest, x1: x, x2: undefined, y, z, fill, stroke}));
}
10 changes: 5 additions & 5 deletions test/output/aaplClose.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions test/plots/aapl-close.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ test(async function aaplClose() {
return Plot.plot({
y: {grid: true},
marks: [
Plot.areaY(aapl, {x: "Date", y: "Close", fillOpacity: 0.1}),
Plot.lineY(aapl, {x: "Date", y: "Close"}),
Plot.areaLineY(aapl, {x: "Date", y: "Close"}),
Plot.ruleY([0])
]
});
Expand Down
Loading