fix: use CLAUDE_PLUGIN_ROOT for brainstorming script paths (issue #1134)#1727
Open
ElizioMartins wants to merge 1 commit into
Open
fix: use CLAUDE_PLUGIN_ROOT for brainstorming script paths (issue #1134)#1727ElizioMartins wants to merge 1 commit into
ElizioMartins wants to merge 1 commit into
Conversation
…a#1134) Update visual-companion.md to reference scripts via \/skills/brainstorming/scripts/ instead of relative paths. Fixes the issue where agents look for start-server.sh in the plugin root (superpowers/5.0.7/scripts/) instead of the skill directory (superpowers/5.0.7/skills/brainstorming/scripts/). Updated references: - start-server.sh (6 occurrences across platform examples) - stop-server.sh (1 occurrence) - frame-template.html (1 occurrence) - helper.js (1 occurrence)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR?
What problem are you trying to solve?
Issue #1134: Claude Code Opus frequently can't find the visual companion start script. The
visual-companion.mdguide referencesscripts/start-server.shbut the actual script lives atskills/brainstorming/scripts/start-server.sh. Agents read the guide and try to runscripts/start-server.shfrom the plugin root, which fails with "no such file or directory".What does this PR change?
Updates all script references in
skills/brainstorming/visual-companion.mdto use${CLAUDE_PLUGIN_ROOT}/skills/brainstorming/scripts/prefix:start-server.sh(6 occurrences across platform-specific examples)stop-server.sh(1 occurrence)frame-template.html(1 occurrence)helper.js(1 occurrence)This ensures agents use the correct absolute path regardless of where they're running from.
Is this change appropriate for the core library?
Yes - this affects all users of the brainstorming skill's visual companion feature across all harnesses.
What alternatives did you consider?
Alternative would be to copy scripts to plugin root, but that duplicates files. Using
CLAUDE_PLUGIN_ROOT(set by Claude Code) is the intended pattern per existing hooks and RELEASE-NOTES.md.Does this PR contain multiple unrelated changes?
No - single cohesive change updating all script references in one file.
Existing PRs
Environment tested
Evaluation
Rigor
Human review