feat: add GitHub issue-closing keywords to PR template (issue #600)#1726
Open
ElizioMartins wants to merge 4 commits into
Open
feat: add GitHub issue-closing keywords to PR template (issue #600)#1726ElizioMartins wants to merge 4 commits into
ElizioMartins wants to merge 4 commits into
Conversation
Add a mandatory self-identification disclosure (model, harness, harness version, all installed plugins) to the PR template and all three issue templates, and document the requirement in the contributor guidelines. We weigh contributions differently depending on what produced them: content reasoned from documentation is held to a different bar than work grounded in a real session. Also state explicitly, in both CLAUDE.md and the PR template, that all PRs must target the dev branch rather than main.
- skills/test-driven-development/SKILL.md: remove @ from testing-anti-patterns.md reference - skills/writing-skills/SKILL.md: remove @ from testing-skills-with-subagents.md reference The @ prefix is not a valid markdown convention and doesn't resolve to the actual file. Both files exist in the same directory as the referencing SKILL.md.
…ssue obra#1090) Adds keep-coding-instructions: true to the YAML frontmatter of all 14 skills: - brainstorming - dispatching-parallel-agents - executing-plans - finishing-a-development-branch - receiving-code-review - requesting-code-review - subagent-driven-development - systematic-debugging - test-driven-development - using-git-worktrees - using-superpowers - verification-before-completion - writing-plans - writing-skills This preserves user's CLAUDE.md coding instructions when skills are invoked, per Claude Code 2.1.94+ feature.
- Add 'Closes #<issue-number>' placeholder in PR body template - Add guidance to check for related GitHub issues before creating PR - Documents supported closing keywords: Closes, Fixes, Resolves This enables auto-closing of issues when PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR?
What problem are you trying to solve?
Issue #600: When the
finishing-a-development-branchskill creates a PR (Option 2), it generates a PR body with Summary and Test Plan sections but doesn't prompt the user to link related GitHub issues using closing keywords (Closes #123,Fixes #123,Resolves #123).This means issues that are fully resolved by the PR don't get auto-closed on merge, requiring manual cleanup.
What does this PR change?
Closes #<issue-number>placeholder in the PR body template (Option 2)Closes,Fixes,Resolves(case-insensitive)Is this change appropriate for the core library?
Yes - this affects all users creating PRs via the skill, regardless of project domain.
What alternatives did you consider?
Alternative would be to auto-detect related issues from commit messages or branch names, but that adds complexity and may be inaccurate. The explicit placeholder approach is simple and matches GitHub's documented pattern.
Does this PR contain multiple unrelated changes?
No - single cohesive change to the PR template and guidance.
Existing PRs
Environment tested
Evaluation
Rigor
Human review