feat: add keep-coding-instructions: true to all skill frontmatters (issue #1090)#1724
Open
ElizioMartins wants to merge 3 commits into
Open
feat: add keep-coding-instructions: true to all skill frontmatters (issue #1090)#1724ElizioMartins wants to merge 3 commits into
ElizioMartins wants to merge 3 commits into
Conversation
Add a mandatory self-identification disclosure (model, harness, harness version, all installed plugins) to the PR template and all three issue templates, and document the requirement in the contributor guidelines. We weigh contributions differently depending on what produced them: content reasoned from documentation is held to a different bar than work grounded in a real session. Also state explicitly, in both CLAUDE.md and the PR template, that all PRs must target the dev branch rather than main.
- skills/test-driven-development/SKILL.md: remove @ from testing-anti-patterns.md reference - skills/writing-skills/SKILL.md: remove @ from testing-skills-with-subagents.md reference The @ prefix is not a valid markdown convention and doesn't resolve to the actual file. Both files exist in the same directory as the referencing SKILL.md.
…ssue obra#1090) Adds keep-coding-instructions: true to the YAML frontmatter of all 14 skills: - brainstorming - dispatching-parallel-agents - executing-plans - finishing-a-development-branch - receiving-code-review - requesting-code-review - subagent-driven-development - systematic-debugging - test-driven-development - using-git-worktrees - using-superpowers - verification-before-completion - writing-plans - writing-skills This preserves user's CLAUDE.md coding instructions when skills are invoked, per Claude Code 2.1.94+ feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR?
What problem are you trying to solve?
Issue #1090: When a superpowers skill is invoked, Claude Code replaces the active coding instructions with the skill's prompt, discarding any rules defined in the user's CLAUDE.md (coding style, comment language, security constraints, etc.).
Claude Code 2.1.94 introduced the
keep-coding-instructionsfrontmatter field specifically to prevent this. Adding it to a skill preserves the user's CLAUDE.md alongside the skill prompt instead of replacing it.What does this PR change?
Adds
keep-coding-instructions: trueto the YAML frontmatter of all 14 skills in the repository:This is a one-line change per skill file.
Is this change appropriate for the core library?
Yes - this affects all users of Superpowers regardless of project domain. It ensures superpowers works correctly with user-defined project conventions without silently overriding them.
What alternatives did you consider?
No alternatives - this is the exact solution requested in the issue and matches the Claude Code feature designed for this purpose.
Does this PR contain multiple unrelated changes?
No - all changes are the same one-line addition to each skill's frontmatter for the same purpose.
Existing PRs
Environment tested
Evaluation
keep-coding-instructions: trueto all skill frontmatters please. #1090"Rigor
Human review