Fix/testing anti patterns reference#1723
Open
ElizioMartins wants to merge 2 commits into
Open
Conversation
Add a mandatory self-identification disclosure (model, harness, harness version, all installed plugins) to the PR template and all three issue templates, and document the requirement in the contributor guidelines. We weigh contributions differently depending on what produced them: content reasoned from documentation is held to a different bar than work grounded in a real session. Also state explicitly, in both CLAUDE.md and the PR template, that all PRs must target the dev branch rather than main.
- skills/test-driven-development/SKILL.md: remove @ from testing-anti-patterns.md reference - skills/writing-skills/SKILL.md: remove @ from testing-skills-with-subagents.md reference The @ prefix is not a valid markdown convention and doesn't resolve to the actual file. Both files exist in the same directory as the referencing SKILL.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR?
What problem are you trying to solve?
Issue #1529:
@testing-anti-patterns.mdreference intest-driven-development/SKILL.mduses@prefix that doesn't resolve. Same issue inwriting-skills/SKILL.mdwith@testing-skills-with-subagents.md. The@prefix is not a valid markdown convention.What does this PR change?
Removes
@prefix from two internal file references in SKILL.md files:Is this change appropriate for the core library?
Yes - fixes broken internal references that affect all users regardless of project.
What alternatives did you consider?
Only alternative is documenting
@as a convention, but it's used in only 2 places inconsistently. Removing is simpler and follows existing pattern (all other refs are bare filenames).Does this PR contain multiple unrelated changes?
No - both changes fix the same pattern (@ prefix on internal refs).
Existing PRs
@testing-anti-patterns.mdreference uses@prefix that doesnt resolve #1529 (this issue), no prior PRs found for this fixEnvironment tested
Evaluation
@testing-anti-patterns.mdreference uses@prefix that doesnt resolve #1529"Rigor
Human review