Skip to content

Add Clear button to History page #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dantraynor wants to merge 3 commits into
base: develop
Choose a base branch
from
+88 −4
Open

Add Clear button to History page #804

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2aa80c5
Add Clear button to History page
dantraynor May 6, 2026
83a5c41
Merge branch 'develop' into feature/clear-history-button
dantraynor May 9, 2026
bb10f71
Merge branch 'develop' into feature/clear-history-button
dnzbk May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 80 additions & 4 deletions webui/history.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,54 @@ var History = (new function($)
});
}

this.clearClick = function()
{
RPC.call('history', [true], function(allHistory)
{
if (allHistory.length === 0)
{
PopupNotification.show('#Notif_History_Empty');
return;
}

var hasNzb = false;
var hasDup = false;
var hasFailed = false;
for (var i = 0; i < allHistory.length; i++)
{
var hist = allHistory[i];
hasNzb |= hist.Kind === 'NZB';
hasDup |= hist.Kind === 'DUP';
// Only NZB records carry meaningful Par/Unpack/DeleteStatus; DUP/URL
// rows lack DeleteStatus, which would otherwise spuriously trip != 'NONE'.
hasFailed |= hist.Kind === 'NZB' && (hist.ParStatus === 'FAILURE' ||
hist.UnpackStatus === 'FAILURE' || hist.DeleteStatus != 'NONE');
}

notification = '#Notif_History_Cleared';
HistoryUI.deleteConfirm(
function(command) { clearAction(command, allHistory); },
hasNzb, hasDup, hasFailed, true,
allHistory.length, 0, 100, true);
});
}

function clearAction(command, allHistory)
{
Refresher.pause();

var ids = [];
for (var i = 0; i < allHistory.length; i++)
{
ids.push(allHistory[i].ID);
}

RPC.call('editqueue', [command, '', ids], function()
{
editCompleted();
});
}

function editCompleted()
{
Refresher.update();
Expand Down Expand Up @@ -553,9 +601,12 @@ var History = (new function($)

this.processShortcut = function(key)
{
// keyDown in index.js falls through between tab cases; ignore keys when History isn't active.
if (!activeTab) return false;
switch (key)
{
case 'D': case 'Delete': case 'Meta+Backspace': History.actionClick('DELETE'); return true;
case 'C': History.clearClick(); return true;
case 'P': History.actionClick('REPROCESS'); return true;
case 'N': History.actionClick('REDOWNLOAD'); return true;
case 'M': History.actionClick('MARKSUCCESS'); return true;
Expand Down Expand Up @@ -617,14 +668,31 @@ var HistoryUI = (new function($)
return '<span class="label label-status ' + badgeClass + '">' + statusText + '</span>';
}

this.deleteConfirm = function(actionCallback, hasNzb, hasDup, hasFailed, multi, selCount, pageSelCount, selPercentage)
this.deleteConfirm = function(actionCallback, hasNzb, hasDup, hasFailed, multi, selCount, pageSelCount, selPercentage, clearAll)
{
var dupeCheck = Options.option('DupeCheck') === 'yes';
var dialog = null;

function init(_dialog)
{
dialog = _dialog;
if (clearAll)
{
var html = $('#ConfirmDialog_Text').html();
html = html.replace(/Selected/g, 'All').replace(/selected/g, 'all');
$('#ConfirmDialog_Text').html(html);
$('#ConfirmDialog_OK').text('Clear');
// Clear is always permanent: HistoryDelete on hidden DUPs is a no-op
// and on visible NZBs it just creates new hidden DUPs, leaving rows behind.
Util.show($('#HistoryDeleteConfirmDialog_Options', dialog), false);
Util.show($('#HistoryDeleteConfirmDialog_Simple', dialog), true);
Util.show($('#HistoryDeleteConfirmDialog_DeleteWillCleanup', dialog), hasFailed);
Util.show($('#HistoryDeleteConfirmDialog_DeleteNoCleanup', dialog), !hasFailed);
Util.show($('#HistoryDeleteConfirmDialog_DupAlert', dialog), dupeCheck && hasDup);
Util.show('#ConfirmDialog_Help', false);
HistoryUI.confirmMulti(multi);
return;
}
HistoryUI.confirmMulti(multi);
$('#HistoryDeleteConfirmDialog_Hide', dialog).prop('checked', true);
Util.show($('#HistoryDeleteConfirmDialog_Options', dialog), hasNzb && dupeCheck);
Expand All @@ -637,8 +705,16 @@ var HistoryUI = (new function($)

function action()
{
var hide = $('#HistoryDeleteConfirmDialog_Hide', dialog).is(':checked');
var command = hasNzb && hide ? 'HistoryDelete' : 'HistoryFinalDelete';
var command;
if (clearAll)
{
command = 'HistoryFinalDelete';
}
else
{
var hide = $('#HistoryDeleteConfirmDialog_Hide', dialog).is(':checked');
command = hasNzb && hide ? 'HistoryDelete' : 'HistoryFinalDelete';
}
if (selCount - pageSelCount > 0 && selCount >= 50)
{
PurgeHistoryDialog.showModal(function(){actionCallback(command);}, selCount, selPercentage);
Expand All @@ -649,7 +725,7 @@ var HistoryUI = (new function($)
}
}

ConfirmDialog.showModal('HistoryDeleteConfirmDialog', action, init, selCount);
ConfirmDialog.showModal('HistoryDeleteConfirmDialog', action, init, clearAll ? 1 : selCount);
}

this.confirmMulti = function(multi)
Expand Down
8 changes: 8 additions & 0 deletions webui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,10 @@ <h4 class="alert-heading">Download queue is empty.</h4>
</ul>
</div>

<div class="btn-group">
<button class="btn btn-default" onclick="History.clearClick()" title="Clear all records [C]"><i class="material-icon">delete_sweep</i><span class="btn-caption"> Clear</span></button>
</div>

<!-- STATUS FILTER BUTTONS -->
<div class="btn-group phone-hide">
<button class="btn btn-default history-filter" onclick="History.filter('ALL')" title="Show All [A]">All &nbsp;<span class="badge badge-active" id="History_Badge_ALL">?</span></button>
Expand Down Expand Up @@ -3456,6 +3460,10 @@ <h3>NZBGet Login</h3>
<strong>Please select records first</strong>
</div>

<div id="Notif_History_Empty" data-duration="2000" class="alert alert-error alert-center alert-center-small hide">
<strong>History is empty</strong>
</div>

<div id="Notif_History_CantMark" data-duration="2000" class="alert alert-error alert-center alert-center-small hide">
<strong>Cannot mark URL-records</strong>
</div>
Expand Down
Loading