Replace deprecated speech dictionary hooks with a compatibility bridge - #62
Closed
CaptainStormblade wants to merge 1 commit into
Closed
Replace deprecated speech dictionary hooks with a compatibility bridge#62CaptainStormblade wants to merge 1 commit into
CaptainStormblade wants to merge 1 commit into
Conversation
Owner
|
Hello @CaptainStormblade
|
Owner
|
@CaptainStormblade , unless you provide the required info, I'll close this PR. |
Owner
|
The requested info was not provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Emoticons to work with both legacy and current NVDA speech dictionary APIs. It removes the deprecation-warnings seen on newer NVDA versions and prevents dictionary cleanup from delaying or interfering with NVDA termination.
Changes
filter_speechSequenceextension point when available.SpeechDict,SpeechDictEntry, andEntryTypefrom their new module on current NVDA versions while retaining a fallback for older versions.Testing
python -m unittest discover -s tests -v: 3 tests passed.python -m ruff check .: passed.git diff --check: passed.Compatibility note
On current NVDA versions, Emoticons applies its dictionary through the speech filter instead of adding entries to NVDA's Temporary Dictionary. The entries therefore no longer appear in NVDA's Temporary Dictionary dialog, but the add-on's own Emoticons dictionary dialog remains available.