fix(layer): scope UI variant defaults to docus components - #1395
Merged
Conversation
Remove global `defaultVariants` from app config so overriding Nuxt UI components (e.g. a custom `AppHeaderCenter` with a `NavigationMenu`) no longer inherit forced `highlight`/`variant` styles. Defaults now live as explicit fallbacks in the Docus components themselves. Also limit the mobile header body navigation to first-level sections when `navigation.sub` is set, since deeper levels are handled by the per-section drawer.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
HugoRCD
approved these changes
Jun 16, 2026
larbish
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultVariantsfrom the layer'sapp.config.tsso that overriding a Nuxt UI component (e.g. a customAppHeaderCenterwith aNavigationMenu) no longer inherits forcedhighlight/variantstyles. Previouslyhighlight: truecaused an unwanted bottom border on overridden components.?? ...fallbacks inside the Docus components themselves (contentNavigation,navigationMenu,contentToc), keeping the default look unchanged while no longer leaking onto user overrides.AppHeaderBody) to first-level sections whennavigation.subis set, since deeper levels are already handled by the per-section drawer inDocsAsideMobileBar. Each top-level item links to its first page via the sharedgetFirstPagePathhelper.useUIConfigwhen accessingdefaultVariantson the merged app config.Test plan
AppHeaderCenterwith a customNavigationMenuand confirm there's no forced bottom border / highlight.navigation.subset, confirm the mobile hamburger menu shows only top-level sections, each linking to its first page.