fix: keep bootstrapRef across the VM creation request-id patch - #800
Open
vijayaraghavanr31 wants to merge 1 commit into
Open
vijayaraghavanr31 wants to merge 1 commit into
vijayaraghavanr31 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
===========================================
+ Coverage 43.96% 54.52% +10.56%
===========================================
Files 18 32 +14
Lines 2593 6294 +3701
===========================================
+ Hits 1140 3432 +2292
- Misses 1417 2546 +1129
- Partials 36 316 +280 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thunderboltsid
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.bootstrapRef, because controller-runtime zeros the object before decoding the API response.addGuestCustomizationToVMthen panicked onbootstrapRef.Kindduring the first VM create. The retry usually succeeded, which is why scale tests logged the panic and the cluster often still came up.bootstrapRef, so cloud-init is still applied on the first create. Both guest-customization helpers return an error when the ref is nil instead of panicking.Test plan
go test -count=1 -run 'TestNutanixMachineReconciler_getOrMintVMCreationRequestID|TestAddGuestCustomizationNilBootstrapRef|TestNutanixMachineReconciler_getOrCreateVM' ./controllers/addGuestCustomizationToVMnil-pointer panic on the first VM create