fix: add more logging for task errors (#783) - #790
Merged
Merged
Conversation
abhay-nutanix
requested review from
Vedansh074,
thunderboltsid and
vijayaraghavanr31
September 22, 2026 07:27
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (68.90%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-v1.9 #790 +/- ##
===============================================
Coverage ? 65.76%
===============================================
Files ? 25
Lines ? 2921
Branches ? 0
===============================================
Hits ? 1921
Misses ? 880
Partials ? 120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vijayaraghavanr31
approved these changes
Sep 22, 2026
Vedansh074
approved these changes
Sep 22, 2026
* fix: add more logging for task errors * fix: address review comments on task error logging * fix: unit-tests * fix: tighten the vm creation check
abhay-nutanix
force-pushed
the
issue/logging1.9
branch
from
September 22, 2026 15:45
ba0962d to
2272446
Compare
vijayaraghavanr31
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a Prism parent task fails, CAPX often only surfaces a generic parent-task error. This change waits for converged operations and, on failure, collects error messages from failed child subtasks so machine (and related) status includes the actionable infrastructure reason (for example DHCP pool exhaustion).
ErrorMessagesandLegacyErrorMessagewhen Prism Central fills both with the same string