Fix distance mini-app BVH robustness#67
Conversation
prudhomm
commented
Jun 4, 2026
prudhomm
commented
- closes Fix distance mini-app BVH robustness #66
Fix distance mini-app BVH robustness Fixes #66
prudhomm
added
bug
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: feaefa718d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| option(FEELPP_PROJECT_REQUIRE_TOOLBOXES "Require Feel++ Toolboxes to run cfg/json configurations" ON) | ||
|
|
||
| if ( NOT TARGET Feelpp::feelpp ) | ||
| find_package(Feel++ CONFIG REQUIRED COMPONENTS Toolboxes |
There was a problem hiding this comment.
When configuring a core-only Feel++ install with -DFEELPP_PROJECT_REQUIRE_TOOLBOXES=OFF, this still asks find_package for REQUIRED COMPONENTS Toolboxes, so CMake fails before the later FEELPP_PROJECT_REQUIRE_TOOLBOXES check can allow the build. This makes the new option ineffective for standalone users who only want to build the non-toolbox apps; request the component conditionally or make the package lookup non-required for Toolboxes and let the explicit check decide.
Useful? React with 👍 / 👎.
1 participant
