ci: run ai-review binary from workspace target dir#5
Merged
Conversation
The ai-review crate is a member of the workspace defined at the repository root, so cargo emits the release binary to ./target, not tools/ai-review/target. The Run step pointed at the crate directory and exited 127. Point Run at the workspace target dir and align the rust-cache workspace entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fix the AI Review reusable workflow so the compiled binary is found at runtime.
Root cause
tools/ai-reviewis a member of the workspace defined at the repository root (Cargo.tomlwith[workspace]). Cargo places all build artifacts in the workspace target directory (./target), never in the member crate directory. TheRunstep invoked./tools/ai-review/target/release/ai-review, which never existed, so every run failed with exit code 127. This stayed hidden because callers failed earlier at workflow validation (missing top-levelpermissionsblock).Changes
Runstep now executes./target/release/ai-review.rust-cacheworkspacesentry aligned to the workspace root (.).Validation
Canary after merge: re-run AI Review on an open caller PR (nubster-identity#109) and confirm the
reviewanddescribechecks pass.