Skip to content

team: tame false positives#15

Merged
pierrick-fonquerne merged 7 commits into
mainfrom
feature/team-tame-false-positives
Jun 10, 2026
Merged

team: tame false positives#15
pierrick-fonquerne merged 7 commits into
mainfrom
feature/team-tame-false-positives

Conversation

@pierrick-fonquerne

Copy link
Copy Markdown
Contributor

Scope

  • Confirm a finding only when at least two verification lenses respond and none contest it (strict quorum). A single contestation, or fewer than two responses, leaves the finding contested.
  • Give each lens the real file content around the finding (a windowed head-file view), not just the patch, so a genuine issue whose evidence sits outside the diff is no longer dismissed. The head sha is fetched once per run and reused for inline posting.
  • Scope the security agent to added lines and document common false positives (CI secret references treated as expected usage, untouched permissions out of scope, theoretical issues excluded).

Acceptance criteria

  • A finding with one contesting lens is shown as contested, not confirmed.
  • A finding verified by fewer than two lenses is contested with an explicit reason.
  • Lenses receive the head-file window when the file is line-located and readable.
  • fmt + clippy (all/pedantic, -D warnings) + tests are green (32 tests).

Closes #9
Closes #10

@pierrick-fonquerne pierrick-fonquerne merged commit 3cd7e1b into main Jun 10, 2026
3 checks passed
@pierrick-fonquerne pierrick-fonquerne deleted the feature/team-tame-false-positives branch June 10, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

team: reduce security agent noise team: give lenses access to the head file content

1 participant