team: deterministic prefilter for findings outside the diff#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Synthesised findings sometimes point at a file line that belongs to no hunk of that file's patch. Such findings describe code this pull request does not touch, yet each one costs three lens calls before being contested.
This change adds a deterministic prefilter between synthesis and the lens vote:
github.rs: unified diff hunk range parsing (parse_hunks,parse_hunk_header) andDiffContext::line_in_patch, which reports whether a finding's line falls inside a hunk of its file patchteam.rs:prefilter_verdictcontests a finding whose line is provably outside the diff, with a deterministic reason rendered in the contested section;verify_findingsskips the lens calls for prefiltered findingsFindings with line 0, findings on files without a per-file patch, and findings anchored inside a hunk range keep the current behaviour.
Acceptance criteria
26 tests pass, clippy clean (all + pedantic).
Closes #8