Skip to content

Stack/015: test against 0.11.7 in ci#294

Merged
noib3 merged 1 commit intonoib3:mainfrom
c-c-k:stack/015-pr-test-against-0.11.7-in-ci
Apr 4, 2026
Merged

Stack/015: test against 0.11.7 in ci#294
noib3 merged 1 commit intonoib3:mainfrom
c-c-k:stack/015-pr-test-against-0.11.7-in-ci

Conversation

@c-c-k
Copy link
Copy Markdown
Contributor

@c-c-k c-c-k commented Apr 3, 2026

No description provided.

@c-c-k c-c-k marked this pull request as draft April 3, 2026 18:05
@c-c-k c-c-k marked this pull request as ready for review April 4, 2026 07:30
@noib3
Copy link
Copy Markdown
Owner

noib3 commented Apr 4, 2026

Ideally PRs should be based off of main and not contain commits from other PRs, so pls rebase on main and remove 4744e15 (this also applies to #295 and #296).

@c-c-k
Copy link
Copy Markdown
Contributor Author

c-c-k commented Apr 4, 2026

Sorry, that was my intent, I don't really get how to correctly make a series of stacked commits.

@noib3
Copy link
Copy Markdown
Owner

noib3 commented Apr 4, 2026

While on main, create a new branch and push your commits there. When you want to work on a different feature, checkout main again and create a branch from there.

@c-c-k
Copy link
Copy Markdown
Contributor Author

c-c-k commented Apr 4, 2026

So I should remove all the remaining PR's and do them one at a time?

@noib3
Copy link
Copy Markdown
Owner

noib3 commented Apr 4, 2026

No you don't have to close them, just remove the commits that are already part of other PRs (in this case, remove 4744e15 but keep 0b83bdb).

@c-c-k
Copy link
Copy Markdown
Contributor Author

c-c-k commented Apr 4, 2026

Just a moment, sorry for being slow, this is the first time I'm doing PR's

@c-c-k c-c-k force-pushed the stack/015-pr-test-against-0.11.7-in-ci branch from 0b83bdb to ec0c837 Compare April 4, 2026 07:49
@c-c-k
Copy link
Copy Markdown
Contributor Author

c-c-k commented Apr 4, 2026

Ok, I think I understood how this works now, sorry again.

@noib3 noib3 merged commit bc47c31 into noib3:main Apr 4, 2026
8 of 12 checks passed
@c-c-k c-c-k deleted the stack/015-pr-test-against-0.11.7-in-ci branch April 4, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants