Skip to content

fix(retry-handler): validate response body length against Content-Range #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcollina wants to merge 2 commits into
base: main
Choose a base branch
from
+81 −0
Open

fix(retry-handler): validate response body length against Content-Range #4975

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f407ce7
fix(retry-handler): validate response body length against Content-Range
mcollina Apr 5, 2026
4f1d96d
test(retry): add regression for overlong resumed partial content
mcollina Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/handler/retry-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ class RetryHandler {
this.start = 0
this.end = null
this.etag = null
this.statusCode = null
this.headers = null
}

onResponseStartWithRetry (controller, statusCode, headers, statusMessage, err) {
Expand Down Expand Up @@ -183,6 +185,8 @@ class RetryHandler {
onResponseStart (controller, statusCode, headers, statusMessage) {
this.error = null
this.retryCount += 1
this.statusCode = statusCode
this.headers = headers

if (statusCode >= 300) {
const err = new RequestRetryError('Request failed', statusCode, {
Expand Down Expand Up @@ -320,6 +324,16 @@ class RetryHandler {
}

if (!this.error) {
// Verify that the received body length matches the expected range
// when we have a finite end position (from Content-Length or Content-Range)
if (this.end != null && Number.isFinite(this.end)) {
if (this.start !== this.end + 1) {
throw new RequestRetryError('Content-Range mismatch', this.statusCode, {
headers: this.headers,
data: { count: this.retryCount }
})
}
}
this.retryCount = 0
return this.handler.onResponseEnd?.(controller, trailers)
}
Expand Down
Loading