Skip to content

test: reduce watch mode restart flakiness #63390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trivikr wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

test: reduce watch mode restart flakiness #63390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test/sequential/test-watch-mode-restart-esm-loading-error.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { spawn } from 'node:child_process';
import { writeFileSync } from 'node:fs';
import { inspect } from 'node:util';
import { createInterface } from 'node:readline';
import { setTimeout as sleep } from 'node:timers/promises';

if (common.isIBMi)
common.skip('IBMi does not support `fs.watch()`');
Expand Down Expand Up @@ -112,19 +113,21 @@ try {

// Update file with syntax error
const syntaxErrorContent = `console.log('hello, wor`;
const failedRestart = restart(common.platformTimeout(10_000));
writeFileSync(file, syntaxErrorContent);

await sleep(common.platformTimeout(1000));
Comment on lines +116 to +118
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a LOT of waiting, did you try with lower values as well? Why did you end up choosing e.g. 1s

// Wait for the failed restart
const { stderr: stderr2, stdout: stdout2 } = await restart();
const { stderr: stderr2, stdout: stdout2 } = await failedRestart;
assert.match(stderr2, /SyntaxError: Invalid or unexpected token/);
assert.deepStrictEqual(stdout2, [
`Restarting ${inspect(file)}`,
`Failed running ${inspect(file)}. Waiting for file changes before restarting...`,
]);

const successfulRestart = restart(common.platformTimeout(10_000));
writeFileSync(file, `console.log('hello again, world');`);

const { stderr: stderr3, stdout: stdout3 } = await restart();
await sleep(common.platformTimeout(1000));
const { stderr: stderr3, stdout: stdout3 } = await successfulRestart;

// Verify it recovered and ran successfully
assert.strictEqual(stderr3, '');
Expand Down
Loading