fix bug in check for valid URL - #317
Open
iantaylor-NOAA wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long description of a simple fix:
The changes to
convert_output()in #305 seem to include a copilot error wherecurlGetHeaders(file)is associated with the utils package when it should just be base R.After getting an
Invalid URL.error in a FIMS case study (https://github.com/NOAA-FIMS/case-studies/actions/runs/30038020469/job/89311014050#step:7:26), I tracked down the problem to this line. Because it's wrapped intryCatch(), R can't tell the difference between an invalid URL and a function that doesn't exist, but running outsidetryCatch()makes it clear which one works:I thought of trying to add an additional testthat test to confirm that
convert_output()will work with a valid URL, but the URL above as well as https://raw.githubusercontent.com/pfmc-assessments/petrale/main/models/2023.a050.003_FIMS_case-study_wtatage/Report.sso are not being converted correctly right now, so are not well suited to automated testing.