[feat]: enable user to add a reference line to the plot for each input dat - #315
Draft
Schiano-NOAA wants to merge 11 commits into
Draft
[feat]: enable user to add a reference line to the plot for each input dat#315Schiano-NOAA wants to merge 11 commits into
Schiano-NOAA wants to merge 11 commits into
Conversation
…fron function; replace old ref line code with for loop for multiple lines
Contributor
New version checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the reference line portion of the plot into it's own function --
add_reference_line()-- which gets added to the plot using the (+) operator.This feature automatically applies to each input dat. There are 4 conditions that this feature handles
plot_spawning_biomass(dat=list("mod1"=mod1, "mod2"=mod2), ref_line = "msy")SBmsy is found for each model.plot_spawning_biomass(dat=list("mod1"=mod1, "mod2"=mod2), ref_line = c("msy"=1000, "msy"=1200))In this instance, any name or combinations can be used as long as there is one value for each element in the dat list.plot_spawning_biomass(dat=list("mod1"=mod1, "mod2"=mod2), ref_line = c("msy","target"))ref_line = NULL