Replace Cirrus CI with more Github Workflows jobs#2776
Conversation
|
Maybe add FreeBSD 15.0 to the job matrix alongside 14.4. FreeBSD 13.5 is also still supported, but I recall it having issues in CI. |
We easily could. But I don't think it would give us a useful amount of additional coverage. Nix doesn't currently have any FreeBSD-15-specific functionality. IMHO, testing on FreeBSD 15 isn't worth the CPU cycles. |
Because Cirrus Labs is shutting down soon. This PR adds a FreeBSD x86_64 job that uses vmactions/freebsd-vm. It also adds jobs for FreeBSD/aarch64, NetBSD, Haiku, OpenBSD, and OmniOS, but they're all currently disabled. With a little bit more work, we could combine the existing Solaris job with this one. Fixes nix-rust#2768
There was a problem hiding this comment.
Pull request overview
This PR migrates CI away from Cirrus CI (scheduled to shut down) by removing Cirrus configuration and adding GitHub Actions workflow coverage for additional OSes via vmactions VMs (with only FreeBSD x86_64 currently enabled).
Changes:
- Remove Cirrus CI configuration, documentation references, and the Cirrus-specific test skip macro.
- Add a new GitHub Actions
vmactionsjob to run build/test/clippy/doc in a FreeBSD 14.4 x86_64 VM (with additional OS/arch entries present but commented out). - Clean up docs/README to no longer reference Cirrus CI.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/sys/test_socket.rs |
Removes a Cirrus-only skip for an AF_ALG test. |
test/common/mod.rs |
Deletes the skip_if_cirrus! macro implementation. |
README.md |
Removes the Cirrus CI status badge. |
CONTRIBUTING.md |
Updates CI guidance to remove Cirrus references and CI skip instructions tied to Cirrus. |
.github/workflows/ci.yml |
Adds a vmactions VM-based job (FreeBSD enabled; other OSes disabled via comments). |
.cirrus.yml |
Deletes the Cirrus CI configuration file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Because Cirrus Labs is shutting down soon. This PR adds a FreeBSD x86_64 job that uses vmactions/freebsd-vm. It also adds jobs for FreeBSD/aarch64, NetBSD, Haiku, OpenBSD, and OmniOS, but they're all currently disabled. With a little bit more work, we could combine the existing Solaris job with this one.
Fixes #2768
What does this PR do
Checklist:
CONTRIBUTING.md