Skip to content

fix: respect sessions during estimator wrangling - #559

Merged
mgxd merged 2 commits into
maint/2.15.xfrom
fix/session-filter
Sep 28, 2026
Merged

mgxd merged 2 commits into
maint/2.15.xfrom
fix/session-filter

Conversation

@mgxd

@mgxd mgxd commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Backport for 2.15.x - supersedes #554

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.12%. Comparing base (5dc1099) to head (30c2266).

Files with missing lines Patch % Lines
sdcflows/utils/wrangler.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           maint/2.15.x     #559      +/-   ##
================================================
- Coverage         84.20%   84.12%   -0.08%     
================================================
  Files                30       30              
  Lines              2874     2873       -1     
  Branches            380      381       +1     
================================================
- Hits               2420     2417       -3     
- Misses              380      381       +1     
- Partials             74       75       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgxd
mgxd force-pushed the fix/session-filter branch from bdd33a0 to 30c2266 Compare September 28, 2026 16:07

@effigies effigies left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man this function is convoluted. Good test.

@mgxd
mgxd merged commit 128241b into maint/2.15.x Sep 28, 2026
14 of 16 checks passed
@mgxd
mgxd deleted the fix/session-filter branch September 28, 2026 17:58
mgxd added a commit that referenced this pull request Sep 28, 2026
2.15.1 (September 28, 2026)

Patch release in the 2.15.x series.

This includes a fix for ``find_estimators`` ignoring the requested ``sessions`` whenever ``bids_filters`` were provided.

* FIX: respect sessions during estimator wrangling (#559)

# Conflicts:
#	CHANGES.rst
mgxd added a commit that referenced this pull request Sep 28, 2026
2.15.1 (September 28, 2026)

Patch release in the 2.15.x series.

This includes a fix for ``find_estimators`` ignoring the requested ``sessions`` whenever ``bids_filters`` were provided.

* FIX: respect sessions during estimator wrangling (#559)

# Conflicts:
#	CHANGES.rst
mgxd added a commit that referenced this pull request Sep 28, 2026
2.15.1 (September 28, 2026)

Patch release in the 2.15.x series.

This includes a fix for ``find_estimators`` ignoring the requested ``sessions`` whenever ``bids_filters`` were provided.

* FIX: respect sessions during estimator wrangling (#559)

# Conflicts:
#	CHANGES.rst
mgxd added a commit that referenced this pull request Sep 29, 2026
2.17.1 (September 29, 2026)

Patch release in the 2.17.x series.

This includes a fix for ``find_estimators`` ignoring the requested ``sessions`` whenever ``bids_filters`` were provided.

* FIX: respect sessions during estimator wrangling (#559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants