Skip to content

fix: respect sessions when finding estimators - #554

Open
mgxd wants to merge 2 commits into
mainfrom
fix/session-aware
Open

mgxd wants to merge 2 commits into
mainfrom
fix/session-aware

Conversation

@mgxd

@mgxd mgxd commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

find_estimators discarded the caller's sessions whenever any bids_filters were given, because the session key was popped unconditionally and defaulted to None.

Addresses nipreps/fmriprep#3664

This likely warrants a backport to the 2.15.x series(?) for fmriprep LTS

``find_estimators`` discarded the caller's ``sessions`` whenever any
``bids_filters`` were given, because the session key was popped
unconditionally and defaulted to None.
@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.13%. Comparing base (6619863) to head (0021399).

Files with missing lines Patch % Lines
sdcflows/utils/wrangler.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   84.14%   84.13%   -0.01%     
==========================================
  Files          30       30              
  Lines        2939     2938       -1     
  Branches      400      401       +1     
==========================================
- Hits         2473     2472       -1     
  Misses        388      388              
  Partials       78       78              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgxd
mgxd marked this pull request as ready for review September 15, 2026 12:42
@mgxd
mgxd requested a review from effigies September 15, 2026 14:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant