fix: collect data interactions with sessions and bids filters - #1063
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1063 +/- ##
==========================================
- Coverage 67.15% 67.13% -0.02%
==========================================
Files 54 54
Lines 6850 6847 -3
Branches 852 850 -2
==========================================
- Hits 4600 4597 -3
Misses 2037 2037
Partials 213 213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
effigies
approved these changes
Sep 28, 2026
effigies
pushed a commit
that referenced
this pull request
Sep 28, 2026
* fix: allow bids_filters to narrow sessions in collect_data * tst: verify session / filter behavior
mgxd
added a commit
to nipreps/fmriprep
that referenced
this pull request
Sep 30, 2026
25.2.6 (September 29, 2026) Bug-fix release in the 25.2.x series. This release updates downstream dependencies to fix how session selection interacts with ``--bids-filter-file``. * DOC: Add note on StartTime metadata (#3670) * MNT: Bump niworkflows to 1.15.2 (nipreps/niworkflows#1063) * MNT: Bump sdcflows to 2.15.1 (nipreps/sdcflows#559) * MNT: Fix py310-min tests on CI (#3671)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivated by nipreps/fmriprep#3607
a filter selecting a subset of
session_idlike:raised
Conflicting entities for "session". Instead, filters should allow narrowing from these values, or whensession_id=None. However, the case:should still raise.