Skip to content

Fix code quality issues: sentence case, promise handling, deprecated functions, settings headings #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilsandrey merged 6 commits into from
Mar 9, 2026
Merged

Fix code quality issues: sentence case, promise handling, deprecated functions, settings headings #9

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2aa547
Initial plan
Copilot Mar 9, 2026
a939055
Initial plan checklist
Copilot Mar 9, 2026
6dcc5c2
Fix all code quality issues from ESLint scan
Copilot Mar 9, 2026
c89f213
adding an explicit rejection handle
nilsandrey Mar 9, 2026
f5f9b0c
Update src/transforms/encode.ts
nilsandrey Mar 9, 2026
4c5bd47
Apply review feedback: fix deps, N label, fatal TextDecoder, catch as…
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import tsparser from "@typescript-eslint/parser";
import { defineConfig } from "eslint/config";
import obsidianmd from "eslint-plugin-obsidianmd";
import globals from "globals";

export default defineConfig([
...obsidianmd.configs.recommended,
{
files: ["**/*.ts"],
languageOptions: {
parser: tsparser,
parserOptions: { project: "./tsconfig.json" },
globals: {
...globals.browser,
},
},
rules: {
"obsidianmd/ui/sentence-case": [
"error",
{
// Preserve these proper nouns/acronyms that are not in the default list
ignoreWords: ["UTC", "ISO", "Unix", "GUIDs"],
},
],
},
},
]);
8 changes: 4 additions & 4 deletions main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,10 @@ export default class TextToolsPlugin extends Plugin {

this.addCommand({
id: "join-n-lines",
name: "Join every N lines",
name: "Join every n lines",
editorCallback: (editor) => {
new TwoInputModal(this.app, {
title: "Join every N lines",
title: "Join every n lines",
label1: "N (lines per group)",
Comment thread
nilsandrey marked this conversation as resolved.
Outdated
label2: "Glue",
placeholder1: "2",
Expand Down Expand Up @@ -796,7 +796,7 @@ export default class TextToolsPlugin extends Plugin {
return;
}
this.settings.textSlots[idx] = texts.join("\n");
this.saveSettings();
void this.saveSettings();
Comment thread
nilsandrey marked this conversation as resolved.
Outdated
new Notice(`Text slot ${i} set.`);
},
});
Expand Down Expand Up @@ -844,7 +844,7 @@ export default class TextToolsPlugin extends Plugin {
// =========================================================================

async loadSettings() {
this.settings = Object.assign({}, DEFAULT_SETTINGS, await this.loadData());
this.settings = Object.assign({}, DEFAULT_SETTINGS, (await this.loadData()) as Partial<TextToolsSettings>);
}

async saveSettings() {
Expand Down
Loading